public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 3/3] pif: Remove unused pif_name() function
Date: Mon, 15 Jan 2024 17:39:44 +1100	[thread overview]
Message-ID: <20240115063944.1400285-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20240115063944.1400285-1-david@gibson.dropbear.id.au>

pif_name() has no current callers, although we expect some as we expand the
flow table support.  I'm not sure why this didn't get caught by one of
our static checkers earlier, but it's now causing cppcheck failures for me.

Add a cppcheck suppression.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 pif.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pif.h b/pif.h
index ca85b34..bd52936 100644
--- a/pif.h
+++ b/pif.h
@@ -38,6 +38,7 @@ static inline const char *pif_type(enum pif_type pt)
 		return "?";
 }
 
+/* cppcheck-suppress unusedFunction */
 static inline const char *pif_name(uint8_t pif)
 {
 	return pif_type(pif);
-- 
@@ -38,6 +38,7 @@ static inline const char *pif_type(enum pif_type pt)
 		return "?";
 }
 
+/* cppcheck-suppress unusedFunction */
 static inline const char *pif_name(uint8_t pif)
 {
 	return pif_type(pif);
-- 
2.43.0


  parent reply	other threads:[~2024-01-15  6:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15  6:39 [PATCH 0/3] Assorted fixes David Gibson
2024-01-15  6:39 ` [PATCH 1/3] test: Fix passt.mbuto for cases where /usr/sbin doesn't exist David Gibson
2024-01-15  6:39 ` [PATCH 2/3] treewide: Make a bunch of pointer variables pointers to const David Gibson
2024-01-15  6:39 ` David Gibson [this message]
2024-01-16 22:51 ` [PATCH 0/3] Assorted fixes Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240115063944.1400285-4-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).