From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v4 00/13] Manage more flow related things from generic flow code
Date: Tue, 16 Jan 2024 11:50:30 +1100 [thread overview]
Message-ID: <20240116005043.2212259-1-david@gibson.dropbear.id.au> (raw)
There are a number of things that are more-or-less general to flows
which are still explicitly handled in tcp.c and tcp_splice.c including
allocation and freeing of flow entries, and dispatch of deferred and
timer functions.
Even without adding more fields to the common flow structure, we can
handle a number of these in a more flow-centric way.
Unlike v1 this version is based on the hash table rework series.
Changes since v3:
* Rebased on current tree, plus patches for some test failures
* Renamed "free blocks" to "free clusters" in flow allocation scheme
* Fixed bug where we wouldn't properly merge adjacent free clusters
together during deferred handling
* Improved theory of operation comments about flow allocation scheme
Changes since v2:
* Realised the prealloc/commit functions where confusing and worked
poorly for some future stuff. Replaced with alloc/alloc_cancel
* Fixed a bug where newly allocated flow entries might not be
0-filled, because of the free tracking information in there. This
could cause very subtle problems.
Changes since v1:
* Store the timestamp of last flow timers run in a global, rather
than a ctx field
* Rebased on the TCP hash table rework
* Add patches 9..13/13 with changes to allocation and freeing of flow
entries.
David Gibson (13):
flow: Make flow_table.h #include the protocol specific headers it
needs
treewide: Standardise on 'now' for current timestamp variables
tcp, tcp_splice: Remove redundant handling from tcp_timer()
tcp, tcp_splice: Move per-type cleanup logic into per-type helpers
flow, tcp: Add flow-centric dispatch for deferred flow handling
flow, tcp: Add handling for per-flow timers
epoll: Better handling of number of epoll types
tcp, tcp_splice: Avoid double layered dispatch for connected TCP
sockets
flow: Move flow_log_() to near top of flow.c
flow: Move flow_count from context structure to a global
flow: Abstract allocation of new flows with helper function
flow: Enforce that freeing of closed flows must happen in deferred
handlers
flow: Avoid moving flow entries to compact table
flow.c | 235 +++++++++++++++++++++++++++++++++++++++++++--------
flow.h | 5 +-
flow_table.h | 20 +++++
icmp.c | 12 +--
icmp.h | 2 +-
log.c | 34 ++++----
passt.c | 20 +++--
passt.h | 9 +-
tcp.c | 143 +++++++++----------------------
tcp.h | 2 +-
tcp_conn.h | 8 +-
tcp_splice.c | 49 +++++------
tcp_splice.h | 4 +-
udp.c | 16 ++--
udp.h | 2 +-
15 files changed, 339 insertions(+), 222 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-16 0:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 0:50 David Gibson [this message]
2024-01-16 0:50 ` [PATCH v4 01/13] flow: Make flow_table.h #include the protocol specific headers it needs David Gibson
2024-01-16 0:50 ` [PATCH v4 02/13] treewide: Standardise on 'now' for current timestamp variables David Gibson
2024-01-16 0:50 ` [PATCH v4 03/13] tcp, tcp_splice: Remove redundant handling from tcp_timer() David Gibson
2024-01-16 0:50 ` [PATCH v4 04/13] tcp, tcp_splice: Move per-type cleanup logic into per-type helpers David Gibson
2024-01-16 0:50 ` [PATCH v4 05/13] flow, tcp: Add flow-centric dispatch for deferred flow handling David Gibson
2024-01-16 0:50 ` [PATCH v4 06/13] flow, tcp: Add handling for per-flow timers David Gibson
2024-01-16 0:50 ` [PATCH v4 07/13] epoll: Better handling of number of epoll types David Gibson
2024-01-16 0:50 ` [PATCH v4 08/13] tcp, tcp_splice: Avoid double layered dispatch for connected TCP sockets David Gibson
2024-01-16 0:50 ` [PATCH v4 09/13] flow: Move flow_log_() to near top of flow.c David Gibson
2024-01-16 0:50 ` [PATCH v4 10/13] flow: Move flow_count from context structure to a global David Gibson
2024-01-16 0:50 ` [PATCH v4 11/13] flow: Abstract allocation of new flows with helper function David Gibson
2024-01-16 0:50 ` [PATCH v4 12/13] flow: Enforce that freeing of closed flows must happen in deferred handlers David Gibson
2024-01-16 0:50 ` [PATCH v4 13/13] flow: Avoid moving flow entries to compact table David Gibson
2024-01-23 0:39 ` [PATCH v4 00/13] Manage more flow related things from generic flow code Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116005043.2212259-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).