From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 8E0925A026F for ; Tue, 16 Jan 2024 06:16:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1705382181; bh=4Sj0lNyNKNE7UNyp+rGyzWUbz+ONlswL0cITYmC4iyk=; h=From:To:Cc:Subject:Date:From; b=n1mM5CJWxZDBfO+UpbVi1NpHDetR8SkRYCKlvFT8jJZdtId/u7tbpdIN2Qw5akf5z SrCwbuJbb/Y0+FYDBop4CWqLF7SdvSAl4SBfhQV4GpVpwZrQnCohiw0g9/Er5PmgUd Iy10qamUJM44VomtMmlF2p3IH86oYsoyedqx/QS+3r99Zz6QcAHo1US1j2mLityVaR q4sV8CStZ3qyjeraKQHA87tsYeOQcR0yPbARiGV+PSkLlj2rUNIxJf9f1Qb2qM7hDD t35up86X7JvjmXpaqoDDQo2eTwIS9kPbETzVMFInLClQTuaWw1JA73DmgDBzYSeYvs UJBNesuawBZXQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TDcg90FjSz4wy1; Tue, 16 Jan 2024 16:16:21 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v3 00/11] RFC: ICMP reworks preliminary to flow table integration Date: Tue, 16 Jan 2024 16:16:07 +1100 Message-ID: <20240116051618.2746103-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: EJLRG6F7GLCH2AGFPSS4B2V7SU2FDRPQ X-Message-ID-Hash: EJLRG6F7GLCH2AGFPSS4B2V7SU2FDRPQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: As with TCP, it turns out that there are a bunch of clean ups and reworks to the ICMP code which will make integration with the flow table easier, even before introducing a non-trivial version of the flow table itself. Based on the flow based dispatch/allocation, and bind/addressing cleanup series. Changes since v2: * Rebased on current main and revised flow dispatch series * Standardise on the name 'id_sock' instead of 'id_map' for pointers to specific entries in the id_map * Avoid confusing usage of the word "sequence" to mean a flow of ping packets as opposed to the ping sequence number. * Use packet_get() rather than explicit comparisons to validate packet lengths Changes since v1: * Rebased on newer version of flow dispatch & allocation series * Added 12/12 splitting out close and new sequence functions David Gibson (11): icmp: Don't set "port" on destination sockaddr for ping sockets icmp: Remove redundant initialisation of sendto() address icmp: Don't attempt to handle "wrong direction" ping socket traffic icmp: Don't attempt to match host IDs to guest IDs icmp: Use -1 to represent "missing" sockets icmp: Simplify socket expiry scanning icmp: Share more between IPv4 and IPv6 paths in icmp_tap_handler() icmp: Consolidate icmp_sock_handler() with icmpv6_sock_handler() icmp: Warn on receive errors from ping sockets icmp: Validate packets received on ping sockets icmp: Dedicated functions for starting and closing ping sequences icmp.c | 329 ++++++++++++++++++++++++++++---------------------------- icmp.h | 5 +- passt.c | 4 +- 3 files changed, 166 insertions(+), 172 deletions(-) -- 2.43.0