From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 0ED065A0277 for ; Tue, 6 Feb 2024 02:17:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707182260; bh=xdPcU4lZSaG/Co3GuBd4JOKfnBXY0f1jDzY1xR1kwVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WAPBVoLP26M4zb+Uqo8ucH5LuC+wZZDVI1dlidG/RqnrcS2SaC+YfpY3Y6y2nYOMu 48t3KVjhIiLUwtLcad32UUlZd32jUQjC8YdWOX6JPr7NBWayFD1FvuQeCZKpt8FQC0 sMbHbXHj8YU3TDXLgz344KBXYUuk5P7NusWqSThvWtsyFTSXBMZ8Vk7Xuk+p/rhLL8 EjCtfvylvPUxaPCse88PKJKjIHUOPO5yEwJHOyoJYF/9kK4/jv+A7dHWx+NbnD2VYo l7FYaG5kITqobnmDmA6BdyZipKdCTeVA98VVDfTwB0onsp6NdD8Ch2cIoXXCoFoqtj wBNN4wdYB+CdQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TTQN41FL0z4wys; Tue, 6 Feb 2024 12:17:40 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 14/22] tcp_splice: Merge tcp_splice_new() into its caller Date: Tue, 6 Feb 2024 12:17:26 +1100 Message-ID: <20240206011734.884138-15-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206011734.884138-1-david@gibson.dropbear.id.au> References: <20240206011734.884138-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: SAOEU5Y2LUFY24GWQ575I7KSMJJXQSDA X-Message-ID-Hash: SAOEU5Y2LUFY24GWQ575I7KSMJJXQSDA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The only caller of tcp_splice_new() is tcp_splice_conn_from_sock(). Both are quite short, and the division of responsibilities between the two isn't particularly obvious. Simplify by merging the former into the latter. Signed-off-by: David Gibson --- tcp_splice.c | 63 +++++++++++++++++++++------------------------------- 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/tcp_splice.c b/tcp_splice.c index d1263f21..de5fd95c 100644 --- a/tcp_splice.c +++ b/tcp_splice.c @@ -368,41 +368,6 @@ static int tcp_splice_connect(const struct ctx *c, struct tcp_splice_conn *conn, return 0; } -/** - * tcp_splice_new() - Handle new spliced connection - * @c: Execution context - * @conn: Connection pointer - * @port: Destination port, host order - * @pif: Originating pif of the splice - * - * Return: return code from connect() - */ -static int tcp_splice_new(const struct ctx *c, struct tcp_splice_conn *conn, - in_port_t dstport, uint8_t pif) -{ - sa_family_t af = CONN_V6(conn) ? AF_INET6 : AF_INET; - int s1; - - if (pif == PIF_SPLICE) { - dstport += c->tcp.fwd_out.delta[dstport]; - - s1 = tcp_conn_sock(c, af); - } else { - ASSERT(pif == PIF_HOST); - - dstport += c->tcp.fwd_in.delta[dstport]; - - s1 = tcp_conn_sock_ns(c, af); - } - - if (s1 < 0) { - warn("Couldn't open connectable socket for splice (%d)", s1); - return s1; - } - - return tcp_splice_connect(c, conn, s1, dstport); -} - /** * tcp_splice_conn_from_sock() - Attempt to init state for a spliced connection * @c: Execution context @@ -418,9 +383,11 @@ bool tcp_splice_conn_from_sock(const struct ctx *c, union tcp_listen_epoll_ref ref, union flow *flow, int s0, const union sockaddr_inany *sa) { + in_port_t srcport, dstport = ref.port; struct tcp_splice_conn *conn; union inany_addr src; - in_port_t srcport; + sa_family_t af; + int s1; ASSERT(c->mode == MODE_PASTA); @@ -428,9 +395,11 @@ bool tcp_splice_conn_from_sock(const struct ctx *c, if (!inany_is_loopback(&src)) return false; + af = inany_v4(&src) ? AF_INET : AF_INET6; + conn = FLOW_START(flow, FLOW_TCP_SPLICE, tcp_splice, 0); - conn->flags = inany_v4(&src) ? 0 : SPLICE_V6; + conn->flags = af == AF_INET ? 0 : SPLICE_V6; conn->s[0] = s0; conn->s[1] = -1; conn->pipe[0][0] = conn->pipe[0][1] = -1; @@ -439,7 +408,25 @@ bool tcp_splice_conn_from_sock(const struct ctx *c, if (setsockopt(s0, SOL_TCP, TCP_QUICKACK, &((int){ 1 }), sizeof(int))) flow_trace(conn, "failed to set TCP_QUICKACK on %i", s0); - if (tcp_splice_new(c, conn, ref.port, ref.pif)) + if (ref.pif == PIF_SPLICE) { + dstport += c->tcp.fwd_out.delta[dstport]; + + s1 = tcp_conn_sock(c, af); + } else { + ASSERT(ref.pif == PIF_HOST); + + dstport += c->tcp.fwd_in.delta[dstport]; + + s1 = tcp_conn_sock_ns(c, af); + } + + if (s1 < 0) { + warn("Couldn't open connectable socket for splice (%d)", s1); + conn_flag(c, conn, CLOSING); + return true; + } + + if (tcp_splice_connect(c, conn, s1, dstport)) conn_flag(c, conn, CLOSING); return true; -- 2.43.0