From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id AE0485A0272 for ; Wed, 7 Feb 2024 10:03:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707296637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sK9BYQgJL09jLH1Oi/rCu38AWLhoAi8fsBz9X16dZyU=; b=C04Hcva0Q5BEO4ijJjB9+g94dO/5xL6FhB0X88u1HZPMwmDlgQnYrAlwEC9+9WpVjtVIhE M3+ed5EwQJqyVkj/jad8+v20FIg14psV3z4HAjye/MpawrvXiU3AlgdZX57ENK/iJb1Bqw cqiMTE2PI2ie0hXvgd5BYF9maFefsQc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-a2XqVdutNE2Vhhcp4FHh-w-1; Wed, 07 Feb 2024 04:03:55 -0500 X-MC-Unique: a2XqVdutNE2Vhhcp4FHh-w-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5115f32ca2eso264068e87.2 for ; Wed, 07 Feb 2024 01:03:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707296634; x=1707901434; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sK9BYQgJL09jLH1Oi/rCu38AWLhoAi8fsBz9X16dZyU=; b=bLvatDOot+Ipjnqo8M08icEnwAYdjxo2R5snsIus/c1szzdWbrykPmwCPnDyY3TC+o Q5E6Ka/m6Jsvqssm56dE1BBfayOor9UkbvXy8qY2etPPLKzSX+6b7+bjR8E69K2cRPbk n4rzX+60R9MmT4/eCyRlRSmyQuV5EXQX2hfHEhLC1EP08yFFfKuEWPUq9BT6CZ8mOm5l uTho4BRGNKKFNnBWRE2vobXBGsMKWnRmG/7xgvhEpKFl5zPK7SbjP94LuEc1Ss+eig1x KQg7vh/nMQAdXoJh/F46hCeZTY1Js1JqmDnY9yrf+3rWL3hHZpbi83+rEuE8cjjYcxQM jq1A== X-Gm-Message-State: AOJu0YzOIjEDDvzGfWti2dmkp6Y3vAvjxhmqwH4Xq/Lci+5Uq0aZHm+f Rd9shKNR3477XuquBNKL1LfXPTct1fioJEtcQKw3RHJcL4m2SJjyDNPH6fRiSZKacXdsw7Qgb9J VFx5PyJiCHTGR5w0ZwISgq5RYiMlouNeNyN9fY0RjZLasokA0gQ== X-Received: by 2002:ac2:47fc:0:b0:511:546c:1f14 with SMTP id b28-20020ac247fc000000b00511546c1f14mr3659376lfp.63.1707296634431; Wed, 07 Feb 2024 01:03:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhRIgfemjxTyditZrPd61TKZdYs+v06raIzN/J4VXEzk1fFHaO++3IiNXwOuMm2u+876GChw== X-Received: by 2002:ac2:47fc:0:b0:511:546c:1f14 with SMTP id b28-20020ac247fc000000b00511546c1f14mr3659360lfp.63.1707296634105; Wed, 07 Feb 2024 01:03:54 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWt/v0b0ipdVb/3xZj9gqkdEGcEIX+XcrIlFvswQDDrBn4GnD+YmJlkSO1lDhnQIniEZwLF0Z6rSiMYmFnX/QvuyHPS Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id vu6-20020a170907a64600b00a38891bf4b2sm175557ejc.32.2024.02.07.01.03.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2024 01:03:53 -0800 (PST) Date: Wed, 7 Feb 2024 10:03:19 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 05/24] util: move IP stuff from util.[ch] to ip.[ch] Message-ID: <20240207100319.24c869db@elisabeth> In-Reply-To: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-6-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QFXGCTAIIM6KSNW2PVV2EQF3X65URKEI X-Message-ID-Hash: QFXGCTAIIM6KSNW2PVV2EQF3X65URKEI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Not related to the review of the patch itself: On Mon, 5 Feb 2024 17:13:40 +1100 David Gibson wrote: > On Fri, Feb 02, 2024 at 03:11:32PM +0100, Laurent Vivier wrote: > > > [...] > > > > +struct ipv6hdr { > > Not really in scope for this patch, but I have wondered if we should > try to use struct ip6_hdr from netinet/ip6.h instead of our own > version (derived, I think, from the kernel one). The reason why I went with this is that the one in netinet/ip6.h looks fairly unusable to me: there are no explicit fields for version and priority, and names are long and a bit obscure, as defined by RFC 3542: does 'ctlun' actually mean "control union"? -- Stefano