From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id D86785A0274 for ; Mon, 12 Feb 2024 00:20:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707693600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0ACwqwL9IMYskrNb3cCFxLE2bKyroEUjVeuuuYW4fU=; b=fZPiLkzp78pI6Um32dR9yT8bAW1wcI5XHqGcR6dtYYHDii7vmciP1BCX/nxPGImdaPgMnF a8YRkA2BoSWCoSUH1W7cxhsrhdnHE0Gmfw5OrnMP5wPJgHA24ar6vNazrFxYgiuyqTkPGH CZ2OAeonAgtUTDa1WPxjti3BM2bT0rk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-QxG5nVv0NnyO8pwxpEoaTw-1; Sun, 11 Feb 2024 18:19:58 -0500 X-MC-Unique: QxG5nVv0NnyO8pwxpEoaTw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-560fc724014so1348705a12.2 for ; Sun, 11 Feb 2024 15:19:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707693597; x=1708298397; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h0ACwqwL9IMYskrNb3cCFxLE2bKyroEUjVeuuuYW4fU=; b=MWxPJrx9qxnEgVrIyLSCfFFRf3Kh/755d3E00sYl08COkqVULoDU1TPNgsqnPCXKOk uOZ32rMgQGAEohkFOA4Lc++U9ydh1ez3RG9ww8bJ+pSBtUMT4v2jiSx6OtsQVyvauyeU 6ZW+mOMRuK8TW0W9eUHBCghhFmLH8DIEz8ywWXS70Eur86psuXilbqsJIZa2SFr+H0ly qb7idPxRymXNFFmjslWBoOttu0IbLPczETgqyotVTLOfqk6zk8kMucpFzM6iSryOKOec qCXRAJbbooWMyXTvoP4N6AODQfIAGNkyM6x59BFYEI+Yh2zuNlH9RnsV2QsDyj8h2gE6 gnmg== X-Gm-Message-State: AOJu0YysPNwvZXTXaJXwXFpRGuXyRrgN4/SMWZwUTAlfRmUcwKo5xCOi 4auhWFGtF3UvL2CVzah5F5FlQYp7+kooMC4J2YycNoyjFJMs/N3t92nSIZUC1xot95dHNZwstAp 7yD+wgra95pUrORG8wabj4dqXFsbKzcqoS6fk+g+51628ZdzL20u0cqVN81xl X-Received: by 2002:aa7:d7c9:0:b0:560:58f:7148 with SMTP id e9-20020aa7d7c9000000b00560058f7148mr4201493eds.34.1707693597094; Sun, 11 Feb 2024 15:19:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfbyhvIHg0Gpw/JtdRKq+uoxn+DdLRmwZC1MgphIuNa4h91f+e4lq+4RCaOl54yB3G+PJjIQ== X-Received: by 2002:aa7:d7c9:0:b0:560:58f:7148 with SMTP id e9-20020aa7d7c9000000b00560058f7148mr4201489eds.34.1707693596904; Sun, 11 Feb 2024 15:19:56 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW0OEPcE7LtOnvszo8jkpjTvkPZrxEhNMl5quXxDJQQeUS0283nafn5b4YhnCFrB/jHJRvIoKEreCFJ7z8oxwaUdbP/ Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id fi27-20020a056402551b00b0055edfb81384sm2154406edb.60.2024.02.11.15.19.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2024 15:19:56 -0800 (PST) Date: Mon, 12 Feb 2024 00:19:22 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 20/24] vhost-user: add vhost-user Message-ID: <20240212001922.1baf3db0@elisabeth> In-Reply-To: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-21-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RQQYTLHKITBKHMKBM4K6PZBBKB7MEQQF X-Message-ID-Hash: RQQYTLHKITBKHMKBM4K6PZBBKB7MEQQF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 13:40:33 +1100 David Gibson wrote: > On Fri, Feb 02, 2024 at 03:11:47PM +0100, Laurent Vivier wrote: > > add virtio and vhost-user functions to connect with QEMU. > > > > $ ./passt --vhost-user > > > > and > > > > # qemu-system-x86_64 ... -m 4G \ > > -object memory-backend-memfd,id=memfd0,share=on,size=4G \ > > -numa node,memdev=memfd0 \ > > -chardev socket,id=chr0,path=/tmp/passt_1.socket \ > > I think it would be wise to use different default socket names for > vhost-user than for the qemu socket protocol. I'm not sure if there's an obvious benefit (mix them up, and nothing will work anyway). On the other hand, that means more typing and remembering what's the separator between "passt", "vhost", and "user". > Or even to require > --socket-path: the reasons we have these rather weird default probed > paths don't apply here, AFAICT. Why not, actually? With probed paths, you can still reasonably start passt by *typing* its command line. I do it all the time, and I think it's quite nice to have. -- Stefano