From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 33EF75A0274 for ; Mon, 12 Feb 2024 05:05:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707710731; bh=6fGnom3w8kU43ejOpJFaeJtsif9CbmA219CUNm5wwuY=; h=From:To:Cc:Subject:Date:From; b=aljwJXqcG0ZR5ScqURO/IM+ZrtOCrhSRBHQHxCSMmPH+qXk5zGfhJS7/RHfRnhgy2 TPALQgQ1R5uVoTfzwV524fi98J1HPXSPdq+vKVHss8OKHkVxaHlU0n+KCCAuswEba9 4qQJeHi+0tnYoqp6aBj0GRzK42/RsNw0WKnH0SG/RIKjY8yuySFnYKLB3LX9JfrjXy wAH9YqJk61CUojgAiLCKpOzahLfx421hnsFbtt8W+WVVqzjo9/fqDdOnYOB+dObzw1 UAbybNET14lAtOmQpvvzYaXbsE36AheLjzkkfXFFLm/4frS0vPUov6/c6ljUIn+g19 t/gj4xEHBNZ3w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TY9pz0z3Hz4wyY; Mon, 12 Feb 2024 15:05:31 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH] netlink: Use const rtnh pointer Date: Mon, 12 Feb 2024 15:05:28 +1100 Message-ID: <20240212040528.144416-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 4W4AKNEVTCKGAIU5MX3SVHDIJJOZM7TM X-Message-ID-Hash: 4W4AKNEVTCKGAIU5MX3SVHDIJJOZM7TM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 6c7623d07 ("netlink: Add support to fetch default gateway from multipath routes") inadvertently introduced a new cppcheck warning for a variable which could be a const pointer but isn't. This occurs with cppcheck-2.13.0-1.fc39.x86_64 in Fedora 39 at least. Fixes: 6c7623d07 ("netlink: Add support to fetch default gateway from multipath routes") Signed-off-by: David Gibson --- netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlink.c b/netlink.c index f0b04cb1..9e7cccb4 100644 --- a/netlink.c +++ b/netlink.c @@ -274,7 +274,7 @@ unsigned int nl_get_ext_if(int s, sa_family_t af) if (rta->rta_type == RTA_OIF) { ifi = *(unsigned int *)RTA_DATA(rta); } else if (rta->rta_type == RTA_MULTIPATH) { - struct rtnexthop *rtnh; + const struct rtnexthop *rtnh; rtnh = (struct rtnexthop *)RTA_DATA(rta); ifi = rtnh->rtnh_ifindex; -- 2.43.0