From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5B1BD5A0276 for ; Mon, 12 Feb 2024 17:58:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707757081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMFEGzS8UPiCi7STav6nCRhqiqkuDMdnbZRvsIlbCx4=; b=C97d+BfhKoI+fbdfbnLjSNrrIJsLvOl0GlhhRA/Ku1L2HJ1GVFYXBoLkIC5K2QAUo03dbZ qKm3PfvxaOWs7mEfDSbi3OYnq69SYbWBfrVQyI3YAjPWMBIyjzHCVwE2hewm/jlwLy+rPz PDWuTlKtCjbYxyHY8Y1MBANmDIbS8Hs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-WiJ39o9IOzCWPPOrh3TcPA-1; Mon, 12 Feb 2024 11:57:58 -0500 X-MC-Unique: WiJ39o9IOzCWPPOrh3TcPA-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-560f41972easo1933593a12.0 for ; Mon, 12 Feb 2024 08:57:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707757076; x=1708361876; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IMFEGzS8UPiCi7STav6nCRhqiqkuDMdnbZRvsIlbCx4=; b=tvRTvSFXJ0pgVEt6WaErYe9ZNmEDybVrDhw3xNYKLMVq/wnU/Of7takT432L3q+JTR jYtDgjKt08nty/9PI9v2wQci/6t5Cmo7opu/qTIn6TplmeZszpTcJ1iySiiVXiEb0bU0 O6rs+Nq1n73PzyBkKq7PjgEOIYSW+g0AShd6sfqqCiAKghM1RaKHuMQkfIHu/z+cwg7U Ce+HR3T9amf8N99gHxONW3k6phyMZETcV+ivANEgSJjPDm/sppKVmvxSQwKX6KMNec7O 1v2byIH3zDBb0hYaC6PkA+2UUVKDPtgjzodjMhAZXYSrHv2vlVcOiWRfmyBSaAfjjKfY FFCg== X-Gm-Message-State: AOJu0YwGcp2BqQOpLY07zAZjjzyN4rcm+wAwdJFsd2aysUeSNAVUFxSB 9gHx0djV/PrImPVVLTkJXWYlrW6FaCBmWPCzcrcuAE6Ss6w7O61Rtvaf7kB2zwlWxV9R+v+A/ep q5ggk4e2qCIBndBbw4+JH1onsTLzRpVQ0jhgl6rTFLrzwj5amIbtt4NX2J5/p X-Received: by 2002:a17:906:e916:b0:a3b:b947:af77 with SMTP id ju22-20020a170906e91600b00a3bb947af77mr4606766ejb.67.1707757076365; Mon, 12 Feb 2024 08:57:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7IYzJVPZgZmVUErIEuInHeBXHI3Bon9swJk7d4sC98eIKw6XqP6yRBI1Xbl9RuKEZ1puE2A== X-Received: by 2002:a17:906:e916:b0:a3b:b947:af77 with SMTP id ju22-20020a170906e91600b00a3bb947af77mr4606763ejb.67.1707757076224; Mon, 12 Feb 2024 08:57:56 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id a22-20020a170906685600b00a3cabc9aba9sm375261ejs.109.2024.02.12.08.57.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2024 08:57:55 -0800 (PST) Date: Mon, 12 Feb 2024 17:57:21 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] netlink: Use const rtnh pointer Message-ID: <20240212175721.1efd632c@elisabeth> In-Reply-To: <20240212040528.144416-1-david@gibson.dropbear.id.au> References: <20240212040528.144416-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: YLPIK67L7HDEYUH2RX7B6QWLN2TAZEY5 X-Message-ID-Hash: YLPIK67L7HDEYUH2RX7B6QWLN2TAZEY5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 15:05:28 +1100 David Gibson wrote: > 6c7623d07 ("netlink: Add support to fetch default gateway from multipath > routes") inadvertently introduced a new cppcheck warning for a variable > which could be a const pointer but isn't. This occurs with > cppcheck-2.13.0-1.fc39.x86_64 in Fedora 39 at least. Oops, sorry, I didn't switch to 2.13 yet. On the other hand it's probably not bad that I lag a bit behind, so that we keep checking things on two/three versions. -- Stefano