From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 2EF635A0279 for ; Tue, 13 Feb 2024 16:23:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707837814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKNcPB4ZNuommTO0pm+G+ic/tk5qRjj3mHOk3sXdE3k=; b=YgkxzgKmB4RcHF1ySaLUrKOGTKR/lJdz9xNlloUzIGEqZYlseSrKhXN4GlDV+VPvTwW4Ci DArrJMx/E09ozTLInQnisMQ0cuInhE5+6QOTqd2rzdEjykqm2WeE3hIeowoS0BiGyQjZ7Z 4wX7kOsQc8gIR7N9cVAf15vG8MFjeC8= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-4FO3GQf0NGOT82z4mtoktg-1; Tue, 13 Feb 2024 10:23:32 -0500 X-MC-Unique: 4FO3GQf0NGOT82z4mtoktg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-511535180b4so3506763e87.2 for ; Tue, 13 Feb 2024 07:23:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707837811; x=1708442611; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TKNcPB4ZNuommTO0pm+G+ic/tk5qRjj3mHOk3sXdE3k=; b=Nk5x7ci/RkzNaKQjUcxaZOU1JU4cT0YAsohHfHFrAVORWdq+Eu0svKgp7+UyUBHedL SwYiLVjv1zkquIP1ZtXG9k9pVYm4a7HHJzS5Q2DpK6MBBcQZrF4nAhMNX4S5XZrL/I7H TZWluTJ9sqFbTqBF4FnvKRLiEPiSp/wHAFlULodFN18T2LDInD9khwonn25PbVbH2o9o Y61ql8jThe+oVT8O99DRKBCf37AFvxyA6W82qHzzffVww8YshwzvhbgUKe6GKgxSsQ71 ZHhf3O3nC0iAN/SnTIVKAJb7HK/3tOQyLAJQ1MJsrYVbGCBSSa94gnkTemMaK7et30CN K00A== X-Forwarded-Encrypted: i=1; AJvYcCV5odukaV/q/Anrxz7MJjQntNz8sHuRNUMkk2UQDL1MwJWM26pOy8dz7KZB8woCtx7ucr3kSkg3cGHv4c1jNCjmZI/H X-Gm-Message-State: AOJu0YzRsLOY4FqDvfUbDBumxWo0gDxc2p7zXmcHC0koecbWYx0NcKhO HBMXixBsu50PsQhfgoHTJNSxH+3lKjytpw0Hoi0l6Z8Roxkr2kYGtDNXkCmH+4sKDjctDXVrnpx u8Q1PipFAEpxNiMKQUj6JNSR3hq3DWtsGI34cgspGJFHg0EZIpA== X-Received: by 2002:a05:6512:282:b0:511:5d0c:4abd with SMTP id j2-20020a056512028200b005115d0c4abdmr6910257lfp.38.1707837811258; Tue, 13 Feb 2024 07:23:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3/wdemHaG9JlxrpwMn2FRuzGM2CDMrJmkOMoqlr9k3RMCEHKwMlzsq2FAzsTFKxiLqO8XNA== X-Received: by 2002:a05:6512:282:b0:511:5d0c:4abd with SMTP id j2-20020a056512028200b005115d0c4abdmr6910238lfp.38.1707837810886; Tue, 13 Feb 2024 07:23:30 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUBjAek6BAKhTOSJZMOpI9V2SYLJg/Oo1uKIicai/Lfll9q2+B8+T74/G7PEF/f0XbrMElxxKeVZIT0rK1esnw6BPo7 Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id vw3-20020a170907a70300b00a36c5b01ef3sm1383398ejc.225.2024.02.13.07.23.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2024 07:23:30 -0800 (PST) Date: Tue, 13 Feb 2024 16:22:56 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 20/24] vhost-user: add vhost-user Message-ID: <20240213162256.0407fd8f@elisabeth> In-Reply-To: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-21-lvivier@redhat.com> <20240212001922.1baf3db0@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VSHQ7LC3FRSOTOA4B5IQ4OYNLRAU7B45 X-Message-ID-Hash: VSHQ7LC3FRSOTOA4B5IQ4OYNLRAU7B45 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 13:47:15 +1100 David Gibson wrote: > On Mon, Feb 12, 2024 at 12:19:22AM +0100, Stefano Brivio wrote: > > On Wed, 7 Feb 2024 13:40:33 +1100 > > David Gibson wrote: > > > > > On Fri, Feb 02, 2024 at 03:11:47PM +0100, Laurent Vivier wrote: > > > > add virtio and vhost-user functions to connect with QEMU. > > > > > > > > $ ./passt --vhost-user > > > > > > > > and > > > > > > > > # qemu-system-x86_64 ... -m 4G \ > > > > -object memory-backend-memfd,id=memfd0,share=on,size=4G \ > > > > -numa node,memdev=memfd0 \ > > > > -chardev socket,id=chr0,path=/tmp/passt_1.socket \ > > > > > > I think it would be wise to use different default socket names for > > > vhost-user than for the qemu socket protocol. > > > > I'm not sure if there's an obvious benefit (mix them up, and nothing > > will work anyway). On the other hand, that means more typing and > > remembering what's the separator between "passt", "vhost", and "user". > > > > > Or even to require > > > --socket-path: the reasons we have these rather weird default probed > > > paths don't apply here, AFAICT. > > > > Why not, actually? With probed paths, you can still reasonably start > > passt by *typing* its command line. I do it all the time, and I think > > it's quite nice to have. > > Uh.. I'm not sure how this would change that. Because one would have to type: ./passt --vhost-user --socket-path /tmp/passt.something instead of ./passt --vhost-user? Sure, sometimes I call my sockets /tmp/s, but still that doubles the length of the command line. -- Stefano