From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 98A885A027B for ; Wed, 14 Feb 2024 10:15:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707902129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UUK/J0NSY0t+NzLB3ErwbR0zjcdrF/zk8b750UGQnjs=; b=XhUovpYaNWKrevRPsYPUwXJxp4BKOPiRqMHHscrSswVs6eGs1knNcu80cxHxfKlJHIbYxl +668eSukPfgzjU7sYhfxsgH/GWaKrxfnn+iKHq8tsGeORw5Iat+7SAYpNgoGt22qHvpPdt jQ1RH0oGBCtAJfRoUmZQDybXUNdHE0E= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-b6q4PDEUMI2ENGtg6A0l2w-1; Wed, 14 Feb 2024 04:15:28 -0500 X-MC-Unique: b6q4PDEUMI2ENGtg6A0l2w-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a26f2da3c7bso277201966b.0 for ; Wed, 14 Feb 2024 01:15:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707902126; x=1708506926; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UUK/J0NSY0t+NzLB3ErwbR0zjcdrF/zk8b750UGQnjs=; b=TI9dawsat5erkrxZgN5lsgP6Js/lxEjSQTfaVvNF8qCePHgHU3ISs/poQYDfGteYen dCwEb5NTYYoXLSnorxSfi3aMVZuZZGScIVUJio4MrBpaxUJZnC0NWnBUDc4BKLrbrxwQ rxAEZovKwkMq1qr+3ufFyXPPA2iPKwkfyB7VyP9PTkOedhBEYsnGm7W+ZXOxtpXnC/ZF HpR2pzwEOun17Kk6A6Fa4JbNk2yxuy5MPDkkJFeHfFMyAhs2KFgZoiXs99qofmo0lAQl V07N8aSAzLjtn1bZNjN8cjinF1T5/hzD7m7U9QEV4aygxk2AZmzHV5/zugGjrJNFRIdE g7mQ== X-Gm-Message-State: AOJu0Yw4HtbAdwWFbSRul4mpgkCOsXjeB+vFEfKWpatYk6ohhzpWD5wX FKQyPBjvrcY56/6Bi95SQHEicc4Ykh5j1IWxYx38nTu8h56wbxDRyCCW88Xu8JanxDoi7SZ+RhF GKt5/MWku2R4NYecBe9UN5ioZbnM0aHNBPz5fbf+lk0DPkiA4/GTjkw7UCCl2 X-Received: by 2002:a17:906:b48:b0:a3c:2a66:3fdd with SMTP id v8-20020a1709060b4800b00a3c2a663fddmr1432004ejg.17.1707902126246; Wed, 14 Feb 2024 01:15:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IENX+J9bB3y7BXmK56lSZACJFqJgV/SAhg8lHJ9g6Q6UOZmSKALrpUclQ5yYVdssWUsuM41MQ== X-Received: by 2002:a17:906:b48:b0:a3c:2a66:3fdd with SMTP id v8-20020a1709060b4800b00a3c2a663fddmr1431986ejg.17.1707902125846; Wed, 14 Feb 2024 01:15:25 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id tj3-20020a170907c24300b00a3ce84a34efsm1828951ejc.200.2024.02.14.01.15.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2024 01:15:25 -0800 (PST) Date: Wed, 14 Feb 2024 10:14:51 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] netlink: Use const rtnh pointer Message-ID: <20240214101451.12217d24@elisabeth> In-Reply-To: <20240212040528.144416-1-david@gibson.dropbear.id.au> References: <20240212040528.144416-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NVWCZAZW5FN5NV2RBWEU4M4KBI47SZZL X-Message-ID-Hash: NVWCZAZW5FN5NV2RBWEU4M4KBI47SZZL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 15:05:28 +1100 David Gibson wrote: > 6c7623d07 ("netlink: Add support to fetch default gateway from multipath > routes") inadvertently introduced a new cppcheck warning for a variable > which could be a const pointer but isn't. This occurs with > cppcheck-2.13.0-1.fc39.x86_64 in Fedora 39 at least. > > Fixes: 6c7623d07 ("netlink: Add support to fetch default gateway from multipath > routes") > > Signed-off-by: David Gibson Applied. -- Stefano