Re: [PATCH] conf: No routable interface for IPv4 or IPv6 is informational, not a warning

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 16 Feb 2024 13:49:01 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Thu, Feb 15, 2024 at 11:50:59PM +0100, Stefano Brivio wrote:
> > ...Podman users might get confused by the fact that if we can't
> > find a default route for a given IP version, we'll report that as a
> > warning message and possibly just before actual error messages.
> > 
> > However, a lack of routable interface for IPv4 or IPv6 can be a
> > normal circumstance: don't warn about it, just state that as
> > informational message, if those are displayed (they're not in
> > non-error paths in Podman, for example).
> > 
> > Reported-by: Paul Holzinger <pholzing@redhat.com>
> > Link: https://github.com/containers/podman/pull/21563#issuecomment-1937024642
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> I have mixed feelings about this.  On the one hand it's certainly true
> that these messages don't necessarily indicate a problem.  Also that
> we've had people think they were the undelying cause of later hard
> errors, when in fact they were unrelated.
> 
> On the other hand, these messages do indicate that we're entirely
> disabling either IPv4 or IPv6 connectivity.  The fact that this relies
> on having external routability is itself non-obvious (and is something
> we want to remove, but it will take a while).  As an info message, I
> can see people being confused instead that "why is no IPv[46]
> working?" despite no errors or warnings.
> 
> So... maybe reduce to info level, but make the text clearer that we're
> disabling the relevant IP version?

Right, yes, changed in v2.

-- 
Stefano