From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 320045A027E for ; Fri, 16 Feb 2024 06:08:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708060133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sRhh3m/lkjCYYDZW46tWzB+G/n6Bc8nqAE2Nih7dCBU=; b=fezxkPbzkqmvcMEoypii9tIHl/vJeKjchHDVqZQQv797T5+6HcdHTaU+76FENwqsj9CBuH 2zIDMI7kVZEpzgXRFwd29UbX4rp965DB2Todyu6QWwK0b8djHYXQ7KjtFO5gmi2zqLf5gk pCY9VKJvvaFcp3oiSED0A/pFLJCUs+A= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-PF3O0RY_PkuB8dARczrlEA-1; Fri, 16 Feb 2024 00:08:51 -0500 X-MC-Unique: PF3O0RY_PkuB8dARczrlEA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a3d38947c35so94257666b.3 for ; Thu, 15 Feb 2024 21:08:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708060130; x=1708664930; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sRhh3m/lkjCYYDZW46tWzB+G/n6Bc8nqAE2Nih7dCBU=; b=qP+1EQMFoN+Y/mfmv9Czlm7VGDXqP8PY1pJ6zGvM/Vg5YfElI6GoYtgowL7WXnoRyR gJscbmIUgLH9TxIZYe4iTZZYKOCET47rAiXYoTebQcSvV0U6mnB9uYg3L42Mi8WQ/SnX S2ZuOzbfuTYorsGs+xfj0X4+ccB3d99cr14qB7HDk7ScPOBc9Ujw6d0C9lwRocoxmJr8 LoAPhLIHfTqWnbmMi3/RpyteegNiK7oKYwsSKqeVZevP0B+FoDRDXlsaXDA4FILoVFZK AlOpERQVmdl/B+iushJbDLcd0So/fjZJMY2U6BK69zgiOb/n3Lfd6iZKoSfvxMUaXDKs oUVg== X-Gm-Message-State: AOJu0YxZtRIBIRZIDLpB2xy1jtJfwuTM9W/EKu1FNYScCoJ4d/Y5lbDQ lb2Oc5BeUQMjswNsGH2qwFH83InsP2owpYfu1+Cq0H7/YjJhvLDMcecvejow0O53HofdwHyW6rB hC2hXfatginLjoa13AlyN2bUBt/49FifVI2CvLdRjN9B1xRKBXQ== X-Received: by 2002:aa7:c48c:0:b0:561:8452:3634 with SMTP id m12-20020aa7c48c000000b0056184523634mr2494928edq.36.1708060129995; Thu, 15 Feb 2024 21:08:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEv6XJsey7hTY6J9oPFk3HJkxj7A/qWPrTKtq5Zvc0EVmY0IjKorCAylV+9UJcYIU3dDwVCdA== X-Received: by 2002:aa7:c48c:0:b0:561:8452:3634 with SMTP id m12-20020aa7c48c000000b0056184523634mr2494920edq.36.1708060129697; Thu, 15 Feb 2024 21:08:49 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id cs1-20020a0564020c4100b00561c666991csm1166901edb.73.2024.02.15.21.08.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2024 21:08:49 -0800 (PST) Date: Fri, 16 Feb 2024 06:08:00 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] conf: No routable interface for IPv4 or IPv6 is informational, not a warning Message-ID: <20240216060800.170cc979@elisabeth> In-Reply-To: References: <20240215225059.491656-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: V562LFRURVP2LMY54TVS2T6DM3E42OO6 X-Message-ID-Hash: V562LFRURVP2LMY54TVS2T6DM3E42OO6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Feb 2024 13:49:01 +1100 David Gibson wrote: > On Thu, Feb 15, 2024 at 11:50:59PM +0100, Stefano Brivio wrote: > > ...Podman users might get confused by the fact that if we can't > > find a default route for a given IP version, we'll report that as a > > warning message and possibly just before actual error messages. > > > > However, a lack of routable interface for IPv4 or IPv6 can be a > > normal circumstance: don't warn about it, just state that as > > informational message, if those are displayed (they're not in > > non-error paths in Podman, for example). > > > > Reported-by: Paul Holzinger > > Link: https://github.com/containers/podman/pull/21563#issuecomment-1937024642 > > Signed-off-by: Stefano Brivio > > I have mixed feelings about this. On the one hand it's certainly true > that these messages don't necessarily indicate a problem. Also that > we've had people think they were the undelying cause of later hard > errors, when in fact they were unrelated. > > On the other hand, these messages do indicate that we're entirely > disabling either IPv4 or IPv6 connectivity. The fact that this relies > on having external routability is itself non-obvious (and is something > we want to remove, but it will take a while). As an info message, I > can see people being confused instead that "why is no IPv[46] > working?" despite no errors or warnings. > > So... maybe reduce to info level, but make the text clearer that we're > disabling the relevant IP version? Right, yes, changed in v2. -- Stefano