From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id DE8495A0275 for ; Tue, 20 Feb 2024 08:56:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708415774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u4rjaSquwoayxfpYMP7e6ZaJfJ4IX6tFSpfQuInis54=; b=VfOXz2XadcDoyKld8pO1hxl8jibu69PdFqxsfUC1nayjeqa2wfGiJ3VQ9RSvCS9PKsPm1u dCwzBd46fT14Zxq/IoFfqWawRNT7wEiA5KexEtwlGY1iWzBXk0EP6E4ROrL0R00mtV6FMM lMBBxvPGTq9lvPxeEvioxsrlyTfZqhY= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-_YnptyBXOcun248XNpYD8A-1; Tue, 20 Feb 2024 02:56:13 -0500 X-MC-Unique: _YnptyBXOcun248XNpYD8A-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a2f71c83b7eso432243466b.1 for ; Mon, 19 Feb 2024 23:56:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708415770; x=1709020570; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=u4rjaSquwoayxfpYMP7e6ZaJfJ4IX6tFSpfQuInis54=; b=MR3fXoLxGh8H51eY96bU6x+k1/E/bcXwPZSDp5LROE6OgIgHKfzZinARjeuy83+6nJ IZEYsxzcKUNebrgF3AXPdJPw9tQWtweR/SUAuBCc5HlM9AFu4NMyWgfVwTQwCOMpEe/k HoJHiR3wMdqv/pW+MIRUw1BTKc8xFm1Xm/8OCGu9IL2sGLBuiklCtYyb/DojGHnCbg5l i1Acz/a3XWkmlSUsM3t+vqdgN4VKuzK3+6HY04wKjrleyXk3ao2x2jwDuJmxgF0h0MO6 F2yaimSEQe9gyVH3+M3n0NMVeeBi1/EuJ4ZuxszBHpQSIj+7jAxVL9qJmMRUnl0ZZLyC /5nA== X-Gm-Message-State: AOJu0YzGePbLSzQt3X+SLAyC9zG+uLwu1hllcwxuovJTmcnyRkajQTFH xPZ0jhvINJeKTdhN6+ztcz2vV281alm4wETmMRKRANd/m0ti3DZ2/YOrLRPOyg03QmY//GwE+Ce Lvi8HRV24sc3oyQ/9WoE2gYi1mpzg5GDyj2G56Rm2U0TL6CPinVR5Z8dwUOcu X-Received: by 2002:a17:906:251b:b0:a3e:9fd4:d7b3 with SMTP id i27-20020a170906251b00b00a3e9fd4d7b3mr2562331ejb.3.1708415770766; Mon, 19 Feb 2024 23:56:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGp7+2NL8q9ipixX80mmG+AI3VY/eRqwT5dOlkMyJTc1kBcLbzzQmhn/LstPDLuKZu2l/H1iA== X-Received: by 2002:a17:906:251b:b0:a3e:9fd4:d7b3 with SMTP id i27-20020a170906251b00b00a3e9fd4d7b3mr2562321ejb.3.1708415770342; Mon, 19 Feb 2024 23:56:10 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id zh11-20020a170906880b00b00a3ec216ec6csm1245611ejb.45.2024.02.19.23.56.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2024 23:56:09 -0800 (PST) Date: Tue, 20 Feb 2024 08:55:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/2] Fix buffer overrun in UDP setup (bug 80) Message-ID: <20240220085531.13f6263f@elisabeth> In-Reply-To: <20240220024824.2198704-1-david@gibson.dropbear.id.au> References: <20240220024824.2198704-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GACQ4VJEHYAGX3PQH2TZJMWO4OPG4P7C X-Message-ID-Hash: GACQ4VJEHYAGX3PQH2TZJMWO4OPG4P7C X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jk@lutty.net X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 20 Feb 2024 13:48:22 +1100 David Gibson wrote: > Laurent Jacquot pointed out another bug in UDP forwarding that turned > out to also be a nasty buffer overrun. Fix that, and make a minor > cleanup alongside while we're at it. > > Link: https://bugs.passt.top/show_bug.cgi?id=80 > > David Gibson (2): > udp: Assertion in udp_invert_portmap() can be calculated at compile > time > udp: Fix 16-bit overflow in udp_invert_portmap() Applied. -- Stefano