From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 2AA335A026F for ; Tue, 27 Feb 2024 15:23:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709043782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2VQVoJMTvy5iuEvRzR/SxDExk1jLx7UZkPtkMwpdCI=; b=SvLeIuA8EfM+BtKeigjssn4i+oxJuNmTdjNzRixyuy7Pj1kIJ0juD0PND7rCN1I3q+n6HE rntd0ZqGMpdC3Nc5ldRuu7PNHE3wEVqEFwmO8UEYPhU86GYeO1IRy4Jpf9NuwzNo2zw3si IUDH6Qm252QMcbk+oy87AdReNMz9pCc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-WFgrpIMmMqqVBtQBFb-oyA-1; Tue, 27 Feb 2024 09:23:00 -0500 X-MC-Unique: WFgrpIMmMqqVBtQBFb-oyA-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a3f9b549179so255479066b.2 for ; Tue, 27 Feb 2024 06:23:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709043779; x=1709648579; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=j2VQVoJMTvy5iuEvRzR/SxDExk1jLx7UZkPtkMwpdCI=; b=IUu3upSYxsiC1tuf8rlS4m7V61Odx6tB2mjWeMJGZJ/mGJyADsVO9cS+F7HOXKRMhA IAGx1IsA+8IfqDmxswGOES/HeAqBgSmq4IFASTrhXQ47+hu7/Vwe6FRX9NrxHwQC8kM3 t6Wi60txwJLiO2/PipxvtwyLljjX99hAVd2LAy5YaMvkwr9oPen8oo7js56A/c50Bgx6 CG2t6vMebTa7kBmnL2Vo56ICr/6xFYgBajVOEh8pjMIgcIk4dT1XvFwRIrcrAqr++zcr iwQ7ww6gQQY9s5zKj8LN08YW3jInHbjz0hUheGF/Ar9CdbmZYcqa5IBqPPmj98bGgwHs GQiQ== X-Gm-Message-State: AOJu0Yziw7hwlty/xTTnI8BQ1x+uMaO2tbevVlS28Jtl7ToEuZ17yqkf 7CEAOz9TouNOlDmFjMwezK6aSAXiZ89H3CwOGR714RXpydMQDK6PSnll++HdY8b1QZJ3mBlSh4s 8Q+11NC0J+sSFb9njgTo3uDZQqF8CIyRfsezNak0qxEPy7KzyHFloo4/eVLOc X-Received: by 2002:a17:906:36cd:b0:a3f:af82:569f with SMTP id b13-20020a17090636cd00b00a3faf82569fmr6915463ejc.33.1709043778999; Tue, 27 Feb 2024 06:22:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHY4az3SOwstQq+I7qtWOsB96eu2fkeFqu7iQ3TZvG0cR93StI+beXwhVHPHeBRVzK2Jjtr1g== X-Received: by 2002:a17:906:36cd:b0:a3f:af82:569f with SMTP id b13-20020a17090636cd00b00a3faf82569fmr6915453ejc.33.1709043778680; Tue, 27 Feb 2024 06:22:58 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id bg26-20020a170906a05a00b00a3d0a094574sm812490ejb.66.2024.02.27.06.22.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2024 06:22:58 -0800 (PST) Date: Tue, 27 Feb 2024 15:22:24 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/6] tcp: Improve error handling around socket pools Message-ID: <20240227152224.5bea16c8@elisabeth> In-Reply-To: <20240219075651.1360229-1-david@gibson.dropbear.id.au> References: <20240219075651.1360229-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HPGJPOAK3T7JKQJPK6TF6YUUFPPIYG4I X-Message-ID-Hash: HPGJPOAK3T7JKQJPK6TF6YUUFPPIYG4I X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 19 Feb 2024 18:56:45 +1100 David Gibson wrote: > To reduce latency, the TCP code maintains several pools of ready to > connect TCP sockets. This patch series contains a number of > improvements to improve error handling and reporting when we're unable > to refill these pools, or unable to obtain a socket from these pools. > > David Gibson (6): > treewide: Use sa_family_t for address family variables > tcp: Don't stop refilling socket pool if we find a filled entry > tcp: Stop on first error when refilling socket pools > tcp, tcp_splice: Issue warnings if unable to refill socket pool > tcp, tcp_splice: Helpers for getting sockets from the pools > tcp: Don't store errnos in socket pool Applied (with minor changes as mentioned for 4/6 and 6/6). -- Stefano