From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Paul Holzinger <pholzing@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH 1/2] passt: make --quiet set the log level to warning
Date: Tue, 27 Feb 2024 15:27:01 +0100 [thread overview]
Message-ID: <20240227152701.63e39d71@elisabeth> (raw)
In-Reply-To: <ZdhTUFzOZnZJc1aa@zatzit>
On Fri, 23 Feb 2024 19:12:00 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Thu, Feb 22, 2024 at 06:17:39PM +0100, Paul Holzinger wrote:
> > Based on the man page and help output --quiet hides informational
> > messages. This means that warnings should still be logged. This was
> > discussed in[1].
> >
> > [1] https://archives.passt.top/passt-dev/20240216114304.7234a83f@elisabeth/T/#m42652824644973674e84baf9e0bf1d0e88104450
> >
> > Signed-off-by: Paul Holzinger <pholzing@redhat.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> in terms of implementing what it says it does. Stefano, your call on
> whether this is something we want to do, or whether updating the docs
> would be better.
No, no, I was actually suggesting this change: "quiet" seems to better
suited to describe the fact that we cut down on messages that are not
fundamental, but warnings arguably are -- even though the distinction
between error and warning is still useful for a system logger, I guess.
--
Stefano
next prev parent reply other threads:[~2024-02-27 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 17:17 [PATCH 1/2] passt: make --quiet set the log level to warning Paul Holzinger
2024-02-22 17:17 ` [PATCH 2/2] conf: set the log level much earlier Paul Holzinger
2024-02-23 8:10 ` David Gibson
2024-02-27 14:27 ` Stefano Brivio
2024-02-23 8:12 ` [PATCH 1/2] passt: make --quiet set the log level to warning David Gibson
2024-02-27 14:27 ` Stefano Brivio [this message]
2024-02-27 14:27 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227152701.63e39d71@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).