[PATCH] conf: If no interface with a default route was found, say it

[PATCH] conf: If no interface with a default route was found, say it

[Stefano Brivio]

...instead of implying that by stating that there's no routable
interface for a given IP version. There might be interfaces with
non-default routes.

Suggested-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 conf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf.c b/conf.c
index 17cf279..fb77272 100644
--- a/conf.c
+++ b/conf.c
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
 		ifi = nl_get_ext_if(nl_sock, AF_INET);
 
 	if (!ifi) {
-		info("No routable interface for IPv4: IPv4 is disabled");
+		info("No interface with a default route for IPv4: disabling IPv4");
 		return 0;
 	}
 
@@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
 		ifi = nl_get_ext_if(nl_sock, AF_INET6);
 
 	if (!ifi) {
-		info("No routable interface for IPv6: IPv6 is disabled");
+		info("No interface with a default route for IPv6: disabling IPv6");
 		return 0;
 	}
 
-- 
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
 		ifi = nl_get_ext_if(nl_sock, AF_INET);
 
 	if (!ifi) {
-		info("No routable interface for IPv4: IPv4 is disabled");
+		info("No interface with a default route for IPv4: disabling IPv4");
 		return 0;
 	}
 
@@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
 		ifi = nl_get_ext_if(nl_sock, AF_INET6);
 
 	if (!ifi) {
-		info("No routable interface for IPv6: IPv6 is disabled");
+		info("No interface with a default route for IPv6: disabling IPv6");
 		return 0;
 	}
 
-- 
2.39.2

Re: [PATCH] conf: If no interface with a default route was found, say it

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On Tue, Feb 27, 2024 at 05:29:49PM +0100, Stefano Brivio wrote:
> ...instead of implying that by stating that there's no routable
> interface for a given IP version. There might be interfaces with
> non-default routes.
> 
> Suggested-by: Paul Holzinger <pholzing@redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/conf.c b/conf.c
> index 17cf279..fb77272 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
>  		ifi = nl_get_ext_if(nl_sock, AF_INET);
>  
>  	if (!ifi) {
> -		info("No routable interface for IPv4: IPv4 is disabled");
> +		info("No interface with a default route for IPv4: disabling IPv4");
>  		return 0;
>  	}
>  
> @@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
>  		ifi = nl_get_ext_if(nl_sock, AF_INET6);
>  
>  	if (!ifi) {
> -		info("No routable interface for IPv6: IPv6 is disabled");
> +		info("No interface with a default route for IPv6: disabling IPv6");
>  		return 0;
>  	}
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] conf: If no interface with a default route was found, say it

[Paul Holzinger]

On 27/02/2024 17:29, Stefano Brivio wrote:
> ...instead of implying that by stating that there's no routable
> interface for a given IP version. There might be interfaces with
> non-default routes.
>
> Suggested-by: Paul Holzinger <pholzing@redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: Paul Holzinger <pholzing@redhat.com>