From mboxrd@z Thu Jan 1 00:00:00 1970
Received: by passt.top (Postfix, from userid 1000)
id 16D9F5A0278; Tue, 27 Feb 2024 17:29:49 +0100 (CET)
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: [PATCH] conf: If no interface with a default route was found, say it
Date: Tue, 27 Feb 2024 17:29:49 +0100
Message-Id: <20240227162949.2442048-1-sbrivio@redhat.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID-Hash: RLBCMRSEDQQ3N5MK7C7RFQQFC4LIGL6U
X-Message-ID-Hash: RLBCMRSEDQQ3N5MK7C7RFQQFC4LIGL6U
X-MailFrom: sbrivio@passt.top
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Paul Holzinger <pholzing@redhat.com>
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20240227162949.2442048-1-sbrivio@redhat.com/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/RLBCMRSEDQQ3N5MK7C7RFQQFC4LIGL6U/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>
...instead of implying that by stating that there's no routable
interface for a given IP version. There might be interfaces with
non-default routes.
Suggested-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/conf.c b/conf.c
index 17cf279..fb77272 100644
--- a/conf.c
+++ b/conf.c
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET);
if (!ifi) {
- info("No routable interface for IPv4: IPv4 is disabled");
+ info("No interface with a default route for IPv4: disabling IPv4");
return 0;
}
@@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET6);
if (!ifi) {
- info("No routable interface for IPv6: IPv6 is disabled");
+ info("No interface with a default route for IPv6: disabling IPv6");
return 0;
}
--
2.39.2