public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
	Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 1/7] iov: add some functions to manage iovec
Date: Thu, 29 Feb 2024 09:09:32 +0100	[thread overview]
Message-ID: <20240229090837.0a75863b@elisabeth> (raw)
In-Reply-To: <20240228015206.1214242-2-david@gibson.dropbear.id.au>

On Wed, 28 Feb 2024 12:52:00 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> From: Laurent Vivier <lvivier@redhat.com>
> 
> Introduce functions to copy to/from a buffer from/to an iovec array,
> to compute data length in in bytes of an iovec and to copy memory from
> an iovec to another.
> 
> iov_from_buf(), iov_to_buf(), iov_size(), iov_copy().
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Message-ID: <20240217150725.661467-2-lvivier@redhat.com>
> [dwg: Small changes to suppress cppcheck warnings]
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

I have a long list of style comments on this one, but nothing
functional, so I'll go ahead and apply it to unblock this series, and
post fix-up patches later.

-- 
Stefano


  reply	other threads:[~2024-02-29  8:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  1:51 [PATCH v2 0/7] Allow more use of iovecs in pcap and tap interfaces David Gibson
2024-02-28  1:52 ` [PATCH v2 1/7] iov: add some functions to manage iovec David Gibson
2024-02-29  8:09   ` Stefano Brivio [this message]
2024-02-28  1:52 ` [PATCH v2 2/7] iov: Add helper to find skip over first n bytes of an io vector David Gibson
2024-02-29  8:10   ` Stefano Brivio
2024-02-29 23:05     ` David Gibson
2024-02-28  1:52 ` [PATCH v2 3/7] pcap: Update pcap_frame() to take an iovec and offset David Gibson
2024-02-28  1:52 ` [PATCH v2 4/7] util: Add write_remainder() helper David Gibson
2024-02-28  1:52 ` [PATCH v2 5/7] pcap: Handle short writes in pcap_frame() David Gibson
2024-02-28  1:52 ` [PATCH v2 6/7] pcap: Allow pcap_frame() and pcap_multiple() to take multi-buffer frames David Gibson
2024-02-28  1:52 ` [PATCH v2 7/7] tap: Use write_remainder() in tap_send_frames_passt() David Gibson
2024-02-29  8:11 ` [PATCH v2 0/7] Allow more use of iovecs in pcap and tap interfaces Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229090837.0a75863b@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).