From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E2A855A0275 for ; Thu, 29 Feb 2024 09:11:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709194271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQpDBdA9ukNHnvofcibO/X5C6Z/gvEPFGHBugItuLdU=; b=LEtJlmGnBAsfSByr+L2Q/8cpmz4BxEJSgZPf/bPsvqq8mCjyFC9zXzeECGaAbhQuNlbQc4 uJWZsZjn/REyVBFp8d2rsTvfhtmse9Qqcet0DDEIVN+VwRx4EKJSX9PFBgwy8S2KRFef+B wKRp3gF8Marzk8PolA/4FU++MQIMHNg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-mRppfshhNkmWkI52DP2CrA-1; Thu, 29 Feb 2024 03:11:09 -0500 X-MC-Unique: mRppfshhNkmWkI52DP2CrA-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a3e94bbb22dso56525066b.1 for ; Thu, 29 Feb 2024 00:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709194269; x=1709799069; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oQpDBdA9ukNHnvofcibO/X5C6Z/gvEPFGHBugItuLdU=; b=keK15yxaTxeiWlrguhH7W20Aj4cuqocm8CzybvLC68+pY6AYjdGa3es0+lXfV9FcUQ 3AwwNhAUJJ7AriLtn/+0hgH5uNBXxdS1YHDiVyCHFaEC1iC6T3VBuqcaDY5pdyjrXCgQ JYzpvkkxJfBWNezWRHny+U3ZSnsvxr8A66rSMgnov3GmysSbxeX5U4LyE7r4nbdULr98 4eEEHW+JAJfHB1ca75oz9ohTTxqMgFfU5TAL23uyUyQT6XcCnCbgsNU+Hc51+gjImonp dOaHAPO/9OddS6wAXwTPuV+UO0OTc9vh3ZX42QaCWrDpwBrFSwiVLSr3tUCwAKtgzJz8 8TjQ== X-Gm-Message-State: AOJu0YxsTXdHdpdmPiEh6R3ewu7NI+WMTG8HfZ2A7MB/i1OyxhjJStWF SEFK/vN5OV2JOuB/IFqVSKVzKiP+sEHMWn7VF3br0viVO1PhjkMFi04H+JKOuMUltan9jeilSRP FO/0gPhegiQn1mVaJoPxRLy5T6kKhWGOtOEzWqXzjtXwHvZepqw== X-Received: by 2002:a17:906:e20b:b0:a43:8c43:b702 with SMTP id gf11-20020a170906e20b00b00a438c43b702mr826641ejb.8.1709194268872; Thu, 29 Feb 2024 00:11:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRdaTnx+qlhScK+qJg8X44/yVpdCzJ8uF1+aO/Xyi2g9lXrEgV+5679NHpiVio+urhujb5iQ== X-Received: by 2002:a17:906:e20b:b0:a43:8c43:b702 with SMTP id gf11-20020a170906e20b00b00a438c43b702mr826624ejb.8.1709194268583; Thu, 29 Feb 2024 00:11:08 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id ub10-20020a170907c80a00b00a443a72b136sm427761ejc.177.2024.02.29.00.11.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Feb 2024 00:11:08 -0800 (PST) Date: Thu, 29 Feb 2024 09:10:32 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/5] Assorted small fixes for UDP Message-ID: <20240229091032.5b619194@elisabeth> In-Reply-To: <20240228053929.1570254-1-david@gibson.dropbear.id.au> References: <20240228053929.1570254-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SCSBQ2VGT3PX6CL57PMVI5QFOQCA5B4Z X-Message-ID-Hash: SCSBQ2VGT3PX6CL57PMVI5QFOQCA5B4Z X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 28 Feb 2024 16:39:24 +1100 David Gibson wrote: > Partly in looking at flow table support, partly for other reasons, > I've spotted a number of small fixes that can be made to the UDP code > (in addition to the large fixes I'm still working on). > > These are ready to go now, so here they are. They'll go before the > flow related addressing cleanups. > > Changes since v1: > * Removed patch to unconditionally remove ACT flags, which was Just > Plain Wrong. > * Removed patch to sort out incorrect handling of port flags. While > there's a real bug there, it interacts with at least two more bugs > that I hadn't spotted, complicating the picture. I'll fix those > some other day. > > David Gibson (5): > udp: Don't attempt to translate a 0.0.0.0 source address > udp: Set pif in epoll reference for ephemeral host sockets > udp: Small streamline to udp_update_hdr4() > udp: Fix incorrect usage of IPv6 state in IPv4 path > udp: Remove unnecessary test for unspecified addr_out Applied. -- Stefano