Re: [PATCH v3 00/20] More flow table preliminaries: address handling improvements

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 28 Feb 2024 22:25:00 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> Here's another batch of cleanups and tweaks in preparation for the
> flow table.  This set focuses on improved helpers for handling
> addresses, particularly in the TCP splice path.
> 
> Based on my other series adding more iovecs to the tap and pcap code,
> however the only conflicts should be trivial Makefile collisions.
> 
> Changes since v2:
>  * Minor stylistic and formatting changes based on review
>  * Some clarifying changes to the theory of operation notes on flow
>    lifecycle
>  * Rebased on top of new series cleaning up socket pool error
>    handling.  This removes a couple of patches from this series.
>  * Small edits to commit message for improved clarity
> Changes since v1:
>  * Rebased, and reordered in a way I hope is clearer
>  * Add patch to rename port_fwd.[ch]
>  * Added doc comments to clarify flow life cycle
>  * Added uniform logging of flow start / end to match that lifecycle
>  * union inany_addr typed special address constants
>  * inany based tests for unspecified and multicast addresses, as well
>    as loopback
>  * Dropped patch allowing NULL parameter to inany_from_af(), turned
>    out not to be that useful
>  * Dropped sockaddr_any_init function, turned out not to be very
>    useful in that form
>  * Added patch enforcing no loopback addresses on tap interface
>  * Added logic to sanity check TCP endpoint addresses
>  * Moved socket creation into tcp_splice_connect()
>  * Moved epoll ref parsing into tcp_listen_handler()
>  * Allowed IN4_IS_*() helpers to work on void * addresses

Applied!

-- 
Stefano