From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 9B2D95A0274 for ; Thu, 29 Feb 2024 11:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709204062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tC8kXDeeTz+SkeClIZHidsnXC0bfjtamQdm3TF3CYOk=; b=B020qcp+HDG1kZ5YB6tkkVTnAUxkZ53OrGyZ532LbQB5B9TimR35c0olKypbEkbCw0QSf/ rWgLldDVUYOVzlb6ffzOfOZqD7G/YUApaBQ/Ry6vqZku0gBxQ1Slx0nI2CzWw06Kfgc2rh p3gH0+9uvn4R3v/kvrEws4zott7xO+c= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-x4UNwMHJMjeG25DEH8iQPw-1; Thu, 29 Feb 2024 05:54:21 -0500 X-MC-Unique: x4UNwMHJMjeG25DEH8iQPw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a3f0efa8804so39955066b.2 for ; Thu, 29 Feb 2024 02:54:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709204060; x=1709808860; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tC8kXDeeTz+SkeClIZHidsnXC0bfjtamQdm3TF3CYOk=; b=G9uGZP3H/vAEJIUG1tn4pwTSWCk66bfgHlpEpubn818tbL4pKZ4rFPCsvdrddlsz0P teWZLP0sl4iTt0Wtz0ahu0E0knSaKCvbb9UCQ3644cXei/tU5aAklhZa2Sc0QnKYgHd4 jZ3SupoI3Oq7Vu41Wok0ekxQEtJ8sLn5qjNrbLi+bukNT9JVm7F/HPD4lUm+IVHguCLx bXr6BWqh+u5WYsCyKVyNeIOD2anVC0+B15lpL5rmq3lADzN3n3C17bsJruuEZ/aUspLV KR0s0759pWjDOIf28Pqx1sQEZMrFeK14kZ9NO3ipW0lOMVVi6WvOzbjqSNzaJtLiZgxr wPTA== X-Gm-Message-State: AOJu0YzeNIIrO4DpZaTt2wXpBu3bbb3hqgFT5R2jFfO5tb3jy+FLbG9k DyrHhDXCn1pYM54msVTNaMSgIPhA4iaqPtAeaWabg7JREWyeeuEkoqCF0so1na6IgZILkvlEuh7 Qobq45EyFZM0jmYdSlKb1TfYcm1JzNQ1kP9AE6HKtvfdCfI1DoQ== X-Received: by 2002:a17:906:f914:b0:a43:e77d:1670 with SMTP id lc20-20020a170906f91400b00a43e77d1670mr1224260ejb.39.1709204060018; Thu, 29 Feb 2024 02:54:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGC5Q0cvfNx7vmGCpqwINE3peLVKpvQo7mt8Zyq4T4qcQxuw2IFjK/tnyrgj31ssUVoGuO9PA== X-Received: by 2002:a17:906:f914:b0:a43:e77d:1670 with SMTP id lc20-20020a170906f91400b00a43e77d1670mr1224247ejb.39.1709204059675; Thu, 29 Feb 2024 02:54:19 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id n26-20020a170906119a00b00a438d594d3esm551741eja.217.2024.02.29.02.54.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Feb 2024 02:54:06 -0800 (PST) Date: Thu, 29 Feb 2024 11:53:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 00/20] More flow table preliminaries: address handling improvements Message-ID: <20240229115331.25a32e69@elisabeth> In-Reply-To: <20240228112520.2078220-1-david@gibson.dropbear.id.au> References: <20240228112520.2078220-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SDGHGCO3CON6N736YJHSKMMWOU3E34NV X-Message-ID-Hash: SDGHGCO3CON6N736YJHSKMMWOU3E34NV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 28 Feb 2024 22:25:00 +1100 David Gibson wrote: > Here's another batch of cleanups and tweaks in preparation for the > flow table. This set focuses on improved helpers for handling > addresses, particularly in the TCP splice path. > > Based on my other series adding more iovecs to the tap and pcap code, > however the only conflicts should be trivial Makefile collisions. > > Changes since v2: > * Minor stylistic and formatting changes based on review > * Some clarifying changes to the theory of operation notes on flow > lifecycle > * Rebased on top of new series cleaning up socket pool error > handling. This removes a couple of patches from this series. > * Small edits to commit message for improved clarity > Changes since v1: > * Rebased, and reordered in a way I hope is clearer > * Add patch to rename port_fwd.[ch] > * Added doc comments to clarify flow life cycle > * Added uniform logging of flow start / end to match that lifecycle > * union inany_addr typed special address constants > * inany based tests for unspecified and multicast addresses, as well > as loopback > * Dropped patch allowing NULL parameter to inany_from_af(), turned > out not to be that useful > * Dropped sockaddr_any_init function, turned out not to be very > useful in that form > * Added patch enforcing no loopback addresses on tap interface > * Added logic to sanity check TCP endpoint addresses > * Moved socket creation into tcp_splice_connect() > * Moved epoll ref parsing into tcp_listen_handler() > * Allowed IN4_IS_*() helpers to work on void * addresses Applied! -- Stefano