From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 00B325A0274 for ; Thu, 29 Feb 2024 15:16:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709216193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFjbcvQD7ZuaczG2gI7jl8Vx07WjrW/Mk7GqOgwW7yo=; b=OJAip8ecnViQ8wWWYRuLxcnPRtqGFHzodcrp/+p8AVv54/EmaAXYcErbin6xAcme8/tsLD aBVAMsd3N1b7K+r1Tw+b27gIAea2N5aF+ymzCNvuP/OMcIQ8K+qUXAFDQfyGlbkvtfDmG4 qgKLSzpacfSLp5h/GmYGU3nR2xDalqo= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-wj3hP94LNgib3YWjVyS--Q-1; Thu, 29 Feb 2024 09:16:31 -0500 X-MC-Unique: wj3hP94LNgib3YWjVyS--Q-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a3e6f366aceso71020166b.3 for ; Thu, 29 Feb 2024 06:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709216189; x=1709820989; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fFjbcvQD7ZuaczG2gI7jl8Vx07WjrW/Mk7GqOgwW7yo=; b=q3rBxgXjvknVitxZQPj9J/ngY4KjYshlFjHN+XXCIZvThYMqDwtDyRrp5RO4WNlO9j 5puodWkq5A93RWvsHLxMQKJUaKQXN4BZ9NIVRscL2XSxDfMXphdR8Rnr+iXD50ddTKJL 64BkDLLsWenyMDiCD7nOQlHJwaH5YJizsb7DP7uDuhbSEhpnRlc7/6Y+4A5Sub1PskVH 2rjXAMJmg1o2l1r0CY+1/hP1L7SAbMnJdZ5qfyVG/01xrclLNNtZrecW0QUa6oSnQuQx Xi47SPQqny6UKKbIBb4DnS2wrYQzI6L7cDNg34Pbb2l6d1vxYnzbEIpjc+LQgyZ9pBcg lKJg== X-Forwarded-Encrypted: i=1; AJvYcCX2tqT1cpX7TGbwr+Xy0We8+pwMfKXzpBd8ASk8JARU42ZSNPOOUPmqpP4iUn3PHtEdmKHbjk2oD3eQnsXkGUu+wEIk X-Gm-Message-State: AOJu0YzDdqfd4IqE5Ov3tEGLWSRN7byHNHY4lsFPSsaPv4INpflQ8hoU SrwbktdTs9vk2W7AR1cacWbpDrRO9X2no3fey/yvFHhdKycNVto8c+hedgOD9ZVLD9mATjdpRNq 8TUATB88OxTqqWRrXOf/bDiWnGdxsCNBvOu1rxN2N9tLWXnPgp37xCxbRhUYS X-Received: by 2002:a17:906:fac5:b0:a3e:c94b:a06d with SMTP id lu5-20020a170906fac500b00a3ec94ba06dmr1545924ejb.57.1709216189558; Thu, 29 Feb 2024 06:16:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7xVU6+aBSIOrltfDQbm0z5VzVi7z41WeymdYmcDJqvM8wh5yp/iBeeLInEft9/afDrQQ04w== X-Received: by 2002:a17:906:fac5:b0:a3e:c94b:a06d with SMTP id lu5-20020a170906fac500b00a3ec94ba06dmr1545900ejb.57.1709216188899; Thu, 29 Feb 2024 06:16:28 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id jg29-20020a170907971d00b00a4412406741sm722982ejc.131.2024.02.29.06.16.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Feb 2024 06:16:28 -0800 (PST) Date: Thu, 29 Feb 2024 15:15:53 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 7/9] checksum: introduce functions to compute the header part checksum for TCP/UDP Message-ID: <20240229151553.60d5cf18@elisabeth> In-Reply-To: <20240229095625.557367ab@elisabeth> References: <20240217150725.661467-1-lvivier@redhat.com> <20240217150725.661467-8-lvivier@redhat.com> <04c99072-02ea-46a9-aac6-23116cb05fa1@redhat.com> <20240229080509.4f534831@elisabeth> <20240229095625.557367ab@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: DSZPGYYFI4W7WYZG7N3TNQOFFAFZ2UYA X-Message-ID-Hash: DSZPGYYFI4W7WYZG7N3TNQOFFAFZ2UYA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 29 Feb 2024 09:56:25 +0100 Stefano Brivio wrote: > On Thu, 29 Feb 2024 19:49:09 +1100 > David Gibson wrote: > > > On Thu, Feb 29, 2024 at 08:05:09AM +0100, Stefano Brivio wrote: > > > On Thu, 29 Feb 2024 11:38:53 +1100 > > > David Gibson wrote: > > > > > > > On Wed, Feb 28, 2024 at 02:26:18PM +0100, Laurent Vivier wrote: > > > > > On 2/19/24 04:08, David Gibson wrote: > > > > > > On Sat, Feb 17, 2024 at 04:07:23PM +0100, Laurent Vivier wrote: > > > > > > > > > > > > [...] > > > > > > > > > > > > > +/** > > > > > > > + * proto_ipv6_header_psum() - Calculates the partial checksum of an > > > > > > > + * IPv6 header for UDP or TCP > > > > > > > + * @payload_len: Payload length > > > > > > > + * @proto: Protocol number > > > > > > > + * @saddr: Source address > > > > > > > + * @daddr: Destination address > > > > > > > + * Returns: Partial checksum of the IPv6 header > > > > > > > + */ > > > > > > > +uint32_t proto_ipv6_header_psum(uint16_t payload_len, uint8_t protocol, > > > > > > > + struct in6_addr saddr, struct in6_addr daddr) > > > > > > > > > > > > Hrm, this is passing 2 16-byte IPv6 addresses by value, which might > > > > > > not be what we want. > > > > > > > > > > The idea here is to avoid the pointer alignment problem (&ip6h->saddr and > > > > > &ip6h->daddr can be misaligned). > > > > > > > > Ah, right. That's a neat idea, but I'm not sure it really helps: I > > > > think it will just move the misaligned access from inside the function > > > > to the call site, where we try to marshal the parameter from something > > > > unaligned. > > > > > > I haven't tested this yet, but note that this is generally okay: the > > > problem is *dereferencing* an unaligned pointer. But if you load memory > > > from an aligned pointer, and extract a value from this memory, it's all > > > fine. > > > > Right, that's kind of what I'm getting at. Assuming this value starts > > in an unaligned buffer, then in order to pass this by value the caller > > will need to load from that unaligned pointer. AFAIK, the compiler > > will base the type of loads only on the pointed to type, which isn't > > changed whether we dereference in the caller or the callee. > > > > > > > > Speaking MIPS, this is not safe on all CPU models: > > > > > > la $1, 1002 # s1 now contains the value 1002 > > > lw $2, 0($1) # load word from memory at 1002 + 0 into s2 > > > > > > but this is: > > > > > > la $1, 1000 # s1 now contains the value 1000 > > > la $2, 1004 # s3 now contains the value 1004 > > > lw $3, 0($1) # load word from memory at 1000 + 0 into s3 > > > lw $4, 0($3) # load word from memory at 1004 + 0 into s4 > > > sll $5, $3, 16 # 16-bit shift left s3 into s5 > > > srl $6, $4, 16 # 16-bit shift right s4 into s6 > > > or $2, $5, $6 # OR s5 and s6 into s2 > > > > Right, but I don't think merely moving the dereference to the caller > > will necessarily induce the compiler to generate this rather than the > > former. > > Oh, oops, I didn't realise this was the case (I haven't reviewed the > patch yet). ...no, that's not the case. Dereferencing 'iph' from struct tcp[46]_l2_buf_t is fine: struct tcp4_l2_buf_t { uint8_t pad[2]; /* 0 2 */ struct tap_hdr taph; /* 2 18 */ struct iphdr iph; /* 20 20 */ [...] } __attribute__((__packed__)); struct tcp6_l2_buf_t { uint8_t pad[2]; /* 0 2 */ struct tap_hdr taph; /* 2 18 */ struct ipv6hdr ip6h; /* 20 40 */ [...] } __attribute__((__packed__)); The problematic structures are the UDP buffers: struct udp4_l2_buf_t { struct sockaddr_in s_in; /* 0 16 */ struct tap_hdr taph; /* 16 18 */ struct iphdr iph; /* 34 20 */ [...] } __attribute__((__aligned__(4))); and for UDP, this patch is dereferencing buffer pointers only, not pointers to headers. Inconsistent if you want, but it's quite simple and it works, plus if you had half a mind (at least for UDP) to split buffers into header and payloads iovec parts... this doesn't need to be exceedingly elegant. -- Stefano