From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 8D25E5A0274 for ; Thu, 29 Feb 2024 17:32:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709224358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SSRigiSuQ6josz9UMAkmlrEKd8cSrQjn+g/C1Lc3X1I=; b=catxD5NLhdNrM54SuPb/sD0uP42Eng1q8MuU4s6+NlOGCvuNo0d9Og5XZy6O3pp4ZJAmsx p4XlA+WDS7g0hGxkvIUoyMVExrDXbf5KZ/vlq/QzEdhM59owejp8RF5jUeWLvZWI0PyNb8 tJUs1iuhvxYJsnqlTJXXg9FUq0PD7Gs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-DVrguOC-NnuGcyCC0fDkRw-1; Thu, 29 Feb 2024 11:32:36 -0500 X-MC-Unique: DVrguOC-NnuGcyCC0fDkRw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a3fcf5b93faso81825066b.2 for ; Thu, 29 Feb 2024 08:32:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709224354; x=1709829154; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SSRigiSuQ6josz9UMAkmlrEKd8cSrQjn+g/C1Lc3X1I=; b=JogYXp/ms1abFGELpMDpW8y87RdG6dGepNz+g3RaHBE4mcLEH5zdPrrajG1Twskv9A IALGNFMsIKqSvnmhrvzeZNS7RRACnC2euvRTLTYcBmcC/5Fe+HVzEyH4bbltJa/R25Er uqk1nc47KGbkfqFy4+xMoNehQhSxBLNfJkrXYKI8HyGxlsg9Il3Zxa8TMApKZodt/HXP CFQy/DMRGND82b+90xYsuh2FU4NxZG3FgWXJXxThebUg3KNjpj6gCmr8ZF7oyVBdZsKS oSF6fX1GeGJw6dngO4LzggsR3UcTj5KfQ+/Y3du696XCBPv4K3IY1JA5ZcrEnXTWRj8E +e6w== X-Gm-Message-State: AOJu0YzXjJYmOM+1pCF6pbX1F0SB4Q9fpFdMOwVJyJXYm1sIIC7+6sX9 BzhBFBZmkbG+J+ZozBn/akljqnYIiwet9XC1AjG53I5KampGLdjZJuTNK+Kc+dXXSvZw2RmtDxj Tul+9J0SbV3UZIrTjHruAMVcbN+3gi9dYptnkbVfkU79MpdMn1twcVB9gSNpEXY3kBqJoDXjN6b a3BZ7sIzYSAFTZ0E5IXPfkB2mbXL51cqwbY9E= X-Received: by 2002:a17:906:4a92:b0:a3f:c006:f141 with SMTP id x18-20020a1709064a9200b00a3fc006f141mr1869014eju.62.1709224354664; Thu, 29 Feb 2024 08:32:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs9lGCHLRF1okmVji9lp4S4woJHWote5id0DuM90ITX8pcAW7o06zl7Iiyf0fJv66xMzr9HA== X-Received: by 2002:a17:906:4a92:b0:a3f:c006:f141 with SMTP id x18-20020a1709064a9200b00a3fc006f141mr1868998eju.62.1709224354307; Thu, 29 Feb 2024 08:32:34 -0800 (PST) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id jt24-20020a170906dfd800b00a412f8601d8sm833542ejc.85.2024.02.29.08.32.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Feb 2024 08:32:33 -0800 (PST) Date: Thu, 29 Feb 2024 17:31:58 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v3 0/9] Add vhost-user support to passt (part 1) Message-ID: <20240229173158.22d3d145@elisabeth> In-Reply-To: <20240217150725.661467-1-lvivier@redhat.com> References: <20240217150725.661467-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: U4VY7G77VMETL4I3LXSRSKBWVL673YEI X-Message-ID-Hash: U4VY7G77VMETL4I3LXSRSKBWVL673YEI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 17 Feb 2024 16:07:16 +0100 Laurent Vivier wrote: > v3: > - add a patch that has been extracted from: > "tcp: extract buffer management from tcp_send_flag()" > -> "tcp: Introduce ipv4_fill_headers()/ipv6_fill_headers()" > - see detailed v3 history log in each patch > - I didn't address the alignment problem when we provide a pointer > to a sub-structure in the internal buffer structure. > (for the last patches of the series). Excluding pending comments, the series looks good to me. -- Stefano