From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
by passt.top (Postfix) with ESMTP id 819B45A026F
for <passt-dev@passt.top>; Tue, 5 Mar 2024 23:12:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1709676778;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=uPqOAsIuINIBWgo+KlJ9gtVGAhWVf5QFXXnwTmngdfk=;
b=dkc0jwSVUf/B0P7+1ebxCoCJEtLDJtT4YkJthOtvwOyIYcAX8orr2IlVeXeT4LCnovfHG+
POirdcVZUi/VsoB1HVBqgy8NYa7bae5T4PMqwXkkYHRr9xgpDlmM5O0ldolYZmGFidRo4E
yyRr8ixKwx8M/zvi0qNbfrDNeOflKUE=
Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com
[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-574-vz4DdBiXMjewSrfZigeuEg-1; Tue, 05 Mar 2024 17:12:56 -0500
X-MC-Unique: vz4DdBiXMjewSrfZigeuEg-1
Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a45b4f09107so17326166b.1
for <passt-dev@passt.top>; Tue, 05 Mar 2024 14:12:55 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1709676774; x=1710281574;
h=content-transfer-encoding:mime-version:organization:references
:in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=uPqOAsIuINIBWgo+KlJ9gtVGAhWVf5QFXXnwTmngdfk=;
b=PQC1ZY63BsGjZksWX7ZQuyFjk7WE4TwOGXd6Kylrg761/NyRgvw7oH27J0GCfsN+jy
ym3cTS9BuGrGZoaeJbKUU0hQIH8zK4aM0QQI7RzkQ6V+0g2QMQeRbt7dKh3C6IBszrTF
uMGFo2tHLqIMmnAl/ZM2ljek/mPJWqjR2qLWIswBsF9ikgm17HC2wIissf7X0wSr0wJ2
6vHkMkqu7ebnsU5Us7ojYUFYZ9XimxO8Pasr5kppWbTTOrsEVvGWXOfXbxbBXQThAZMG
a1llO7loXDDiGHYoyW2RBW4+WOLpzlCWzIwBN+ePf2EGRLGIHg/+XTkhC6CuD61fauI6
I7Qg==
X-Gm-Message-State: AOJu0YyGexgE9l1T2HSBbEpqaYAEWs5CPSA5UVIUUPNy29QY+fsgS9PA
ENNA7mGjvKOFO+7boaf2g5981rF8LlLwztJQAudo/Z6fGKRThkHaQ9avLunzRby8aBzZFVO3TfI
a7BY0AnGXxaTa0n8DjxxvcWmgD/d1RtsbMiEBqhXSxFe/5P8QVNe9f2kjf8G8T6JoyFWOcj3HDw
R5wWXfG8nRdFKBm57YjpM/dpQf1Kd0bDJw8iI=
X-Received: by 2002:a17:906:1185:b0:a43:a7:c67b with SMTP id n5-20020a170906118500b00a4300a7c67bmr9632777eja.28.1709676773818;
Tue, 05 Mar 2024 14:12:53 -0800 (PST)
X-Google-Smtp-Source: AGHT+IGskXWzGh+2M8piiAiZk5tdLPTn2N4HWVhXuEGbPUgltuFvRjWYXpj6G6ULQJ/nM+moPy9ceg==
X-Received: by 2002:a17:906:1185:b0:a43:a7:c67b with SMTP id n5-20020a170906118500b00a4300a7c67bmr9632764eja.28.1709676773282;
Tue, 05 Mar 2024 14:12:53 -0800 (PST)
Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33])
by smtp.gmail.com with ESMTPSA id gq13-20020a170906e24d00b00a45621ded4bsm2456419ejb.146.2024.03.05.14.12.52
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 05 Mar 2024 14:12:52 -0800 (PST)
Date: Tue, 5 Mar 2024 23:12:18 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v5 0/9] Add vhost-user support to passt (part 1)
Message-ID: <20240305231218.149e80a1@elisabeth>
In-Reply-To: <20240303135114.1023026-1-lvivier@redhat.com>
References: <20240303135114.1023026-1-lvivier@redhat.com>
Organization: Red Hat
X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu)
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID-Hash: FZGFYUUO2OJCKQ6ZJGH3FDLGOPQY3KJI
X-Message-ID-Hash: FZGFYUUO2OJCKQ6ZJGH3FDLGOPQY3KJI
X-MailFrom: sbrivio@redhat.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20240305231218.149e80a1@elisabeth/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/FZGFYUUO2OJCKQ6ZJGH3FDLGOPQY3KJI/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>
On Sun, 3 Mar 2024 14:51:05 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> v5:
> - add a patch to cleanup before change:
> udp: little cleanup in udp_update_hdrX() to prepare future changes
> - see detailed v5 history log in each patch
I'm about to apply this, but cppcheck (2.10) tells me (with make
cppcheck):
checksum.c:195:33: style: inconclusive: Function 'csum_icmp4' argument 1 names different: declaration 'ih' definition 'icmp4hr'. [funcArgNamesDifferent]
void csum_icmp4(struct icmphdr *icmp4hr, const void *payload, size_t len)
^
checksum.h:23:33: note: Function 'csum_icmp4' argument 1 names different: declaration 'ih' definition 'icmp4hr'.
void csum_icmp4(struct icmphdr *ih, const void *payload, size_t len);
^
checksum.c:195:33: note: Function 'csum_icmp4' argument 1 names different: declaration 'ih' definition 'icmp4hr'.
void csum_icmp4(struct icmphdr *icmp4hr, const void *payload, size_t len)
^
pcap.c:145:47: style: inconclusive: Function 'pcap_iov' argument 2 names different: declaration 'n' definition 'iovcnt'. [funcArgNamesDifferent]
void pcap_iov(const struct iovec *iov, size_t iovcnt)
^
pcap.h:12:47: note: Function 'pcap_iov' argument 2 names different: declaration 'n' definition 'iovcnt'.
void pcap_iov(const struct iovec *iov, size_t n);
^
pcap.c:145:47: note: Function 'pcap_iov' argument 2 names different: declaration 'n' definition 'iovcnt'.
void pcap_iov(const struct iovec *iov, size_t iovcnt)
^
tcp.c:947:45: error: Expression 'tlen,IPPROTO_TCP,(struct in_addr){.s_addr=iph->saddr},(struct in_addr){.s_addr=iph->daddr}' depends on order of evaluation of side effects [unknownEvaluationOrder]
(struct in_addr){ .s_addr = iph->saddr },
^
checksum.c:506:0: style: The function 'csum_iov' is never used. [unusedFunction]
uint16_t csum_iov(struct iovec *iov, size_t n, uint32_t init)
^
pcap.c:145:0: style: The function 'pcap_iov' is never used. [unusedFunction]
void pcap_iov(const struct iovec *iov, size_t iovcnt)
^
iov.c:150:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
size_t iov_size(const struct iovec *iov, size_t iov_cnt)
^
they are almost all trivial and I plan to fix them up on merge, but I
still have to look into the initialisation in tcp_update_check_tcp4()
(tcp.c:947:45).
--
Stefano