From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 3BE325A0274 for ; Wed, 13 Mar 2024 15:23:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710339792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aVFeQn0JWoUDomqyhB0DRajpLtKy844y2bzTTK9D/XQ=; b=ck+TXhU05COS0N9sljWL9w63BQvwBLW4LzWCwumfvuB2tcpW2AD4uklZR4WIYQbLU/njsd GDvzfgkVrconZ/mABd0JJRg/+JMFJSCB+dbc16molbdDvDTRdGIImN/+Lssaq//W/iHNlc wyRXelmp53o3GNQP8ulv+cwFVxBITbE= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-PAg0vmhSMZGXXtKKFfFoyw-1; Wed, 13 Mar 2024 10:23:10 -0400 X-MC-Unique: PAg0vmhSMZGXXtKKFfFoyw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a3fcf5b93faso62636466b.2 for ; Wed, 13 Mar 2024 07:23:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710339789; x=1710944589; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aVFeQn0JWoUDomqyhB0DRajpLtKy844y2bzTTK9D/XQ=; b=vAmDW2P9ipO0dH1+brVBwjLiW4/B+D5Av4+6EB21mj8IR0r3Gaekknxxqh4NVBWfM2 iPbiV7J+2QAHaP7/TOD5QGvYP/1WsEeaf0Xu2NbWObdWl+QCIe5dFfbuvlY7P1OHy9YX 9D6Vc9bueeL4VXTnw8Hdkb6xZEEr1pyvFCQebOfYZMeOsnFHrP35O9hYcBQpcu4+LNfn ZlL5Djxweyv91aJl9CT87Yok6Ey5OxedoPq+XRj+zPB8a2ARMmXxuB1ztMrC/v/GDkb1 EJn9xQczzdIIIUF1Ku4n2BD8hGcMmNlsoen0Aa0KJulHAYM47RuKK++sOzJ18LJHCVPM cSDg== X-Gm-Message-State: AOJu0YxJb74+GmMOihdxkTbPsp+zqI6tWiA8f05payCyGziyRt64a1wZ DW7UqIjxUnK3fRgjfXEjkMkqg59WsqG2yvfwZA/3QTqeRO4BJi1hm91CWWh0+PaKMzwAYllxv3j Sl40noizK1SG+TDdBu3foFdFpPxCylP8MbTXBbQZ7s1Qfo+aeVA== X-Received: by 2002:a17:906:49a:b0:a46:29b:d7d8 with SMTP id f26-20020a170906049a00b00a46029bd7d8mr2451998eja.73.1710339789162; Wed, 13 Mar 2024 07:23:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMXF0N4vATLwdSj9Q9UkD2eEkKNw37mwTIYOl6OR/U52wHILD/x5azyfn8Al5BkfPf3MCZ3g== X-Received: by 2002:a17:906:49a:b0:a46:29b:d7d8 with SMTP id f26-20020a170906049a00b00a46029bd7d8mr2451977eja.73.1710339788592; Wed, 13 Mar 2024 07:23:08 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id f5-20020a170906560500b00a4668980c12sm45905ejq.182.2024.03.13.07.23.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2024 07:23:07 -0700 (PDT) Date: Wed, 13 Mar 2024 15:22:34 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tap: Capture only packets that are actually sent Message-ID: <20240313152234.090d8696@elisabeth> In-Reply-To: <20240307112602.1279441-1-lvivier@redhat.com> References: <20240307112602.1279441-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IWOVCDHSHBCMPC7JPGTPBE6C4ORRE7D3 X-Message-ID-Hash: IWOVCDHSHBCMPC7JPGTPBE6C4ORRE7D3 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 7 Mar 2024 12:26:02 +0100 Laurent Vivier wrote: > In tap_send_frames(), if we failed to send all the frames, we must > only log the frames that have been sent, not all the frames we wanted > to send. > > Fixes: dda7945ca9c9 ("pcap: Handle short writes in pcap_frame()") > Cc: david@gibson.dropbear.id.au > Signed-off-by: Laurent Vivier Applied. -- Stefano