From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 4C6645A026F for ; Thu, 14 Mar 2024 05:54:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710392088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H7th21G+TlyxidA7urtamtSO6obKpsetQwCVbMuVVII=; b=Vzl2CLcd33OgwKp5ZEVpkUr/BmX4RDlOOckY2Yyyz46RQ1qBDfrcXgoYRczum7QbaUbFDZ mllNetRFc7XBDjARTDS+lbjJ8Pr+1gjHgvvk3ltaCYPZFAZ4/ZJ4KGG/sY+Q9spbmuSTNu pZi52gWUGSRecOySy42NDY1IdGG1ljE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-CxHKQpYENVWrQbOTRFZnBw-1; Thu, 14 Mar 2024 00:54:47 -0400 X-MC-Unique: CxHKQpYENVWrQbOTRFZnBw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a44143c8908so59660566b.1 for ; Wed, 13 Mar 2024 21:54:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710392086; x=1710996886; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=H7th21G+TlyxidA7urtamtSO6obKpsetQwCVbMuVVII=; b=Su2HiYhONb81mhJuRVJNcrALbLbIrOEOv6vFwIAyU2ChOKQBsgK4QZibJTkzXk9IP7 LqfmsryNaOoha5tpSMat5d/2F4S1MeeOMvgmyxIa/21Uo0/Gn98GQq5vQPkOPhfX6eBo iMxU5+Gxu57BIWcpP4Dw8NPCb2E1fGgep1P1H98J2BeLEN4mppPsM662Sw6wkxuKV3lD gVWFow4/D58kuCcW0lmAG59grGIqGnL+ds03u9V4Vx8wft7JwKf0bDyvb7VZqRlrQ6yz 0fm465DUAUbLqQC6naDFrl3KWulqfzG8vViT+vz/X5D7DjSfWxHj7poc9FLUSlq8Qh6k O5Cg== X-Gm-Message-State: AOJu0Yx5k/G6LjnjJQBdKTStR+owupHM0VK/aHtzT3P0kGuLjq6mirVk Efg+WoXAnSjHauUZU8tKgwVjqu4il67lSl39KojGHCFQt6sRwTvXaPTG8HyMHerdH6eDExIvSH/ APdDdbwry9Nglp9jzD18hJQ6WL/FkPin83BFxaN7E135qiSV20g== X-Received: by 2002:a17:906:c452:b0:a46:29d8:40fb with SMTP id ck18-20020a170906c45200b00a4629d840fbmr505384ejb.22.1710392085787; Wed, 13 Mar 2024 21:54:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESecF9ZyYDipu/ptXESEM34TD36Nsqb8KKg5qtvRHvsCXMqxaZhej5i5laor3pACE4jBxRsw== X-Received: by 2002:a17:906:c452:b0:a46:29d8:40fb with SMTP id ck18-20020a170906c45200b00a4629d840fbmr505374ejb.22.1710392085293; Wed, 13 Mar 2024 21:54:45 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id dx24-20020a170906a85800b00a46623ed98csm302983ejb.175.2024.03.13.21.54.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2024 21:54:44 -0700 (PDT) Date: Thu, 14 Mar 2024 05:54:10 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] conf: Handle addresses passed via --dns just like the ones from resolv.conf Message-ID: <20240314055348.421e7622@elisabeth> In-Reply-To: References: <20240312072136.225197-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GJH3KV2O3A5ZIQ7INE7INRL5YMN3AN4O X-Message-ID-Hash: GJH3KV2O3A5ZIQ7INE7INRL5YMN3AN4O X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 14 Mar 2024 13:17:02 +1100 David Gibson wrote: > On Tue, Mar 12, 2024 at 08:21:36AM +0100, Stefano Brivio wrote: > > ...that is, call add_dns4() and add_dns6() instead of simply adding > > those to the list of servers we advertise. > > > > Most importantly, this will set the 'dns_host' field for the matching > > IP version, so that, as mentioned in the man page, servers passed via > > --dns are used for DNS mapping as well, if used in combination with > > --dns-forward. > > > > Reported-by: Paul Holzinger > > Link: https://bugs.passt.top/show_bug.cgi?id=82 > > Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding") > > Signed-off-by: Stefano Brivio > > Reviewed-by: David Gibson > > This does subtly change semantics: addresses given to --dns are now > host addresses, rather than guest addresses. I think the new meaning > is less cryptic, though. Right, yes. But as we introduced the feature, the man page said, from the beginning: -D, --dns addr Use addr (IPv4 or IPv6) for DHCP, DHCPv6, NDP or DNS forwarding [...] so we have to change/fix semantics, I guess. -- Stefano