From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 5B4565A0272 for ; Tue, 26 Mar 2024 09:55:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711443313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pG7Ytla0aMsQf8OuyIR3TFQAtuin4JFtDb4JKRZPWnE=; b=BxKgmzojc9Fdjsx+6wjti5JKeebwnHdsZZZhAtJZNU9Y2BTWBZX15u9NUhCsOlO7e/m0T+ nzrXYAUm0btMuE0Jadu14FWuwIKm/w72GwHNvFwKPcdPouZmMSZWmtoA7o67KT+sIz01BJ AtOI5ohnCGrYCMCcPig2lfD1ay2d2fo= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-CHGuCApROXi12YhQS3Wq9g-1; Tue, 26 Mar 2024 04:55:11 -0400 X-MC-Unique: CHGuCApROXi12YhQS3Wq9g-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a4df5d5069dso22035966b.1 for ; Tue, 26 Mar 2024 01:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711443310; x=1712048110; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pG7Ytla0aMsQf8OuyIR3TFQAtuin4JFtDb4JKRZPWnE=; b=QqzAkCXTtE31K8TpVl9uoVQMshy/0IY22RoS6/EO1o99J3yP68K5drk4YhDF9GZh3N 6L+F4GPDaI9zz+IKyFRdIdqyeay//vEMdALXCxeKDwb9VbsnbzT4SXNg9TQj45XLfZap nhlsRL+wFbfgDPYJoXW+efPseB9rG6V1vCJwlfFW3lMMh8XIfWaKZNZgwRpIDOhmwZ+X 0HMdc/cpyqJd9DO9f4QSvosKWwe6hC4BnKSgxDvIJHehTRdwwViBtC8w0DZ0UdMHQCh8 ZLYli45zDBzxcuhi0BFAnoT5YwylR+tGOfl7Fx1I8zo2ushIfo+508kNpYN0Sj/geB+w cNVQ== X-Gm-Message-State: AOJu0YxpTt62k/vM3XBjD33/uOYU/RTi82AU71jq4GF+IXV1wZgqKXKU 6FTeNnznE87nTSQA6/haAjU+I+YYh9mIp/kyKOKWE/skcIAnqyT4UQZ06lrkiWWIuxIcXn2iPNQ haxLBNTwFLps0t20GyH0fnPlWaf2I/ZO/G3aEfwb+HFcQcwqlMA== X-Received: by 2002:a17:906:2486:b0:a47:22aa:f8e8 with SMTP id e6-20020a170906248600b00a4722aaf8e8mr6379154ejb.12.1711443309835; Tue, 26 Mar 2024 01:55:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH6mK4KEuU947GOni6glrKqASTT9JTo/1iE7YRuCm3+jSYfefffxOA/kLVMcpvsKz6PrvB2g== X-Received: by 2002:a17:906:2486:b0:a47:22aa:f8e8 with SMTP id e6-20020a170906248600b00a4722aaf8e8mr6379132ejb.12.1711443309302; Tue, 26 Mar 2024 01:55:09 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id v14-20020a1709061dce00b00a46be5c78f4sm4032946ejh.142.2024.03.26.01.55.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2024 01:55:08 -0700 (PDT) Date: Tue, 26 Mar 2024 09:54:29 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] Corrections to seeting of ACK flag in TCP packets Message-ID: <20240326095429.37d08eec@elisabeth> In-Reply-To: <20240326054224.716874-1-david@gibson.dropbear.id.au> References: <20240326054224.716874-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZEHOQ5O5HXJWV34QFPKWJAUPM5VOJUED X-Message-ID-Hash: ZEHOQ5O5HXJWV34QFPKWJAUPM5VOJUED X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, maxi.rostock@outlook.de, pholzing@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 Mar 2024 16:42:20 +1100 David Gibson wrote: > A recently reported podman bug shows transfer failures in podman > custom rootless networks connected with pasta. Analysis suggests this > is triggered by pasta generating a TCP packet without the ACK flag > when it should have one. > > The exact symptoms seem to arise because of some odd kernel behaviour > - rather than simply ignoring the packet, an RST is observed killing > the connection. However, there are also packets seen after the RST > which don't seem to make sense. > > While there are some mysteries which we still hope to track down here, > in the meantime it definitely seems like pasta's ACK behaviour isn't > correct, and appears to trigger the other problems. So, fix it. > > Link: https://github.com/containers/podman/issues/22146 > Link: https://bugs.passt.top/show_bug.cgi?id=84 > > David Gibson (4): > tcp: Split handling of DUP_ACK from ACK > tcp: Rearrange logic for setting ACK flag in tcp_send_flag() > tcp: Never automatically add the ACK flag to RST packets > tcp: Unconditionally force ACK for all !SYN, !RST packets Applied. -- Stefano