From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 02CF05A0276 for ; Fri, 5 Apr 2024 20:10:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712340610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+DkagbwbWZXt1kea2vhAstxwQ5Nw7P+HlIU8S4OmcE=; b=DNee1bHOJ3wKeb92kniyEz+zbTYNTB1CABd+fA+gVv6cE428pUE5VA/8azDYJKqva0/zlP 6ZpvcMRMGPBy2Nq7gl34hErNsj1ebz4BYBNtOGZToSr/X/gatTubFcXOAq9Nwej1DeaDzE 2RCoXu02XI+QaajsmKrDQ3hFU2F+DTY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-GYkyDa9mOECjjOc1UduUbQ-1; Fri, 05 Apr 2024 14:10:09 -0400 X-MC-Unique: GYkyDa9mOECjjOc1UduUbQ-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5685d83ec51so1051302a12.3 for ; Fri, 05 Apr 2024 11:10:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712340607; x=1712945407; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=w+DkagbwbWZXt1kea2vhAstxwQ5Nw7P+HlIU8S4OmcE=; b=w21pS2vTA2poFnc7rrCJhlwfWi8iSDMZAlUwKvGrj8GWFNETk7UAJ2ijET/70NDnCv De+j2NDfJBP5SxDdKheSwkXGFUiD9JK6LdKOxZIITMzN/tP6/zBYM4yTtyjvLbPCVlMn 68bZPcnslRrwQPjzqDvZ0SSOLLTzJ85B/M+/HnZsfp4eBF2gISA2Qgssi/bQsxl325XI qHW+1CPmqPf8+Aky1AnMpWiTnYoS4ToNkl65qEbLTQkLhGjrzY5s9XZ7+NcDFBpjdK6s 0zRHh0aH3mdovjeFS/t1X0QBvLXtj8sWUrkLpaXcriJN8/bL1cWynVhzoL3nJSaKA6I7 r1PA== X-Forwarded-Encrypted: i=1; AJvYcCVrvTQ5RRkXyfOWdnxZtEN6Lk/tQ5fZ2OYn4roE3Hk1ASF7FTYpU0TP9xFkqjMXikJL3aCjBLS0Waggvq10mLJtMR2o X-Gm-Message-State: AOJu0YzuHW5sNk8tWAyJaR0o6aUUd6r/OCdTdhfA+qPn1iT4UE8IYTRk rDF7LTiEhTkAmcxk96FruybcK72Wa96bcATNzCDPKjWCsAINkS+c6t0V/QiKgO0TttRDrjsb/S8 IdsFryLOsDA9TqYmaKojS57TdCYRSu4wBfTiVoBMIIg+UztsyINRYIGqALUHs X-Received: by 2002:a17:907:78d7:b0:a47:5182:3b83 with SMTP id kv23-20020a17090778d700b00a4751823b83mr1741456ejc.61.1712340607287; Fri, 05 Apr 2024 11:10:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlkQ0/HElj6tmS8L5zkUwUtl4HLq6rEvrzYna6v7SxRWhM/rzb8QBDP7OeRa2aw3Ega/CYsw== X-Received: by 2002:a17:907:78d7:b0:a47:5182:3b83 with SMTP id kv23-20020a17090778d700b00a4751823b83mr1741438ejc.61.1712340606763; Fri, 05 Apr 2024 11:10:06 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id j25-20020a1709066dd900b00a473362062fsm1094639ejt.220.2024.04.05.11.10.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2024 11:10:06 -0700 (PDT) Date: Fri, 5 Apr 2024 20:09:32 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 2/4] Remove stale archivemount support Message-ID: <20240405200921.0a1f0318@elisabeth> In-Reply-To: <20240322022739.2746102-3-david@gibson.dropbear.id.au> References: <20240322022739.2746102-1-david@gibson.dropbear.id.au> <20240322022739.2746102-3-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AXJI2XM3KPFYOYUCCI3VXQ6PCBG47PUA X-Message-ID-Hash: AXJI2XM3KPFYOYUCCI3VXQ6PCBG47PUA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: lvivier@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 22 Mar 2024 13:27:37 +1100 David Gibson wrote: > mbuto has two ways of building the initramfs. One is the typical approach > of staging its contents in a temporary directory, then building the > initramfs with cpio. The other is to create an empty initramfs, mount > it with archivemount, and copy things into the mounted archive. > > However, the archivemount approach is broken. I'm not entirely sure why, > but it appears not to properly unmount the archive and retrieve the final. > filled version. The upshot is that if archivemount is installed, then > mbuto generates an empty, gzip-compressed initramfs instead of whatever it > was supposed to. It looks like this has bitrotted from some earlier > working version. > > The archivemount approach is not necessary, and honestly a pretty strange > and roundabout way of building the initramfs. Remove it. There were two reasons behind that: first off, I mistakenly assumed that the kernel could see changes made to the initramfs after boot. Second, it was actually convenient for developing this tool as I could just make directories and copies in half-working images. I also had half a mind about some usage with QEMU rebooting the guest, and the initramfs would change across reboots without having to call mbuto again, for bisections or suchlike. But sure, it turned out to be quite complicated to maintain, and it looks like it has been broken on Fedora for a while now (probably due to differences between fakeroot and fakeroot-ng I didn't take into account), so, with some regrets, I'm fine to drop this now. -- Stefano