Re: [PATCH 3/4] Split "auto" compression mode into its own path

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 22 Mar 2024 13:27:38 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> mbuto supports "auto" compression mode where we detect the fastest
> compressor and use it.  This is structured a bit oddly - cpio_compress()
> first handles the case of an explicitly selected compressor, then handles
> the auto-detected case, redundantly actually implementing the compression
> once it has picked one.

Yes, we don't want to risk keeping around several formats if the
archives are big... but you're not changing this, right?

> Make this a bit clearer: first handle the "auto" case by calling out to
> the testing code, and using that to set the parameter for the specific
> compression path.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  mbuto | 53 ++++++++++++++++++++++++-----------------------------
>  1 file changed, 24 insertions(+), 29 deletions(-)
> 
> diff --git a/mbuto b/mbuto
> index 49d032c..550f76e 100755
> --- a/mbuto
> +++ b/mbuto
> @@ -566,31 +566,11 @@ cpio_init() {
>  	fi
>  }
>  
> -# cpio_compress() - Compress archive, test available methods if none is selected
> +# compress_select() - Try compressors and pick the fastest

Now we can say we pick the fastest, but it's not clear in what: we care
about decompression, so perhaps:

# compress_select() - Try compressors and pick the fastest to decompress image

?

-- 
Stefano