From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC v5] tcp: Replace TCP buffer structure by an iovec array
Date: Fri, 19 Apr 2024 12:40:28 +0200 [thread overview]
Message-ID: <20240419124028.567b54c1@elisabeth> (raw)
In-Reply-To: <20240415170137.664509-1-lvivier@redhat.com>
On Mon, 15 Apr 2024 19:01:37 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> To be able to provide pointers to TCP headers and IP headers without
> worrying about alignment in the structure, split the structure into
> several arrays and point to each part of the frame using an iovec array.
>
> Using iovec also allows us to simply ignore the first entry when the
> vnet length header is not needed.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>
> Notes:
> v5:
> - reformat MSS4/MSS6 macros
> - update structures comments
> - use IP_MAX_MTU
> - rename TCP_IOV_TAP to TCP_IOV_VLEN
> - s/ethernet/Ethernet/
> - split loop in tcp_sock4_iov_init() and tcp_sock6_iov_init()
> - use intermediate variable vnet_len in tcp_data_to_tap()
Applied.
--
Stefano
prev parent reply other threads:[~2024-04-19 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 17:01 [RFC v5] tcp: Replace TCP buffer structure by an iovec array Laurent Vivier
2024-04-19 10:40 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419124028.567b54c1@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).