From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 1FCFD5A0354 for ; Thu, 2 May 2024 16:52:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714661578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yr2s2xnyizJsZ3yqe23u2J+vsLKWi4zgOQCpjah74Kg=; b=aD1P8b2swMxmNCnq6LEma47RVGUt0ePAn+rWz3IZ+Zbbj20ydlqsNapLgdwurbpJUvSWPW SSRObzSzm1iTz9xrCnI/IHchWOwfbPfUWOs8tWNx/ZjISZ9cZrhHN30yNB8mfL8svBJOLq Q8id/d4tjdXh3XG7IIZ8fEmm3CgoA2M= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-1ioRzl3AMfWkZgdRaHbc4A-1; Thu, 02 May 2024 10:52:56 -0400 X-MC-Unique: 1ioRzl3AMfWkZgdRaHbc4A-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-572baf39435so910467a12.1 for ; Thu, 02 May 2024 07:52:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714661575; x=1715266375; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yr2s2xnyizJsZ3yqe23u2J+vsLKWi4zgOQCpjah74Kg=; b=GvYwnwqc+TDndm1Q4s39+HXeJizmR2wKKoQz7oTZXap4JSrGOHbGr0D+4NDuk9jhIU tVB+26gpKkCLqW4Yt/e7pVPYJPOFKDXxvzxoxVhieiTSseq1NtiLWalDN62Q9PRlkoWa 8a3CeDlxCYWRVqdEqUisdnjUs3EqZHTbQ5wg5WY0Q5ez43V55nRK8wLJYn75h0djtFAn QIpR0+wnRQtIjSApzFZmxKF7BkikLcDufpf9KyDIULTJFdng+P1jVsUXEt7+yp+/eldx gx7JTCycbFhK2aOqq7FfC6LhDp0+pcOao3cSXk6FPjUzFf0ZqNVVKbkPm1A9yZKk/0/v Blxg== X-Gm-Message-State: AOJu0YxTYsSZ8cH1E5WW+hpR+gLgH3BI66SaDKG9pX4lZX4vDWuuoWB3 f7meQzoNO0oUZZsl47AAHIHUuPjsn3fhq23qdKycMZnrfjMACQknPIB1Vk6ZNQLs27kDgjCRK8b F7U1Ov47UKfFkxxXRlpuKF1yKb7xnl2fIMpZreprBCpIslFei6Q== X-Received: by 2002:a50:cd53:0:b0:570:4aea:4e1e with SMTP id d19-20020a50cd53000000b005704aea4e1emr2992040edj.15.1714661575105; Thu, 02 May 2024 07:52:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKrrYeIcH7UcsI87THESnTK+9GJg7CJQIqCGB5AIF2HpJrkBY3Gw4nLnT7RSfD1eIeFrUbmw== X-Received: by 2002:a50:cd53:0:b0:570:4aea:4e1e with SMTP id d19-20020a50cd53000000b005704aea4e1emr2992015edj.15.1714661574555; Thu, 02 May 2024 07:52:54 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id n15-20020a05640206cf00b00572b029ca57sm603041edy.25.2024.05.02.07.52.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2024 07:52:53 -0700 (PDT) Date: Thu, 2 May 2024 16:52:20 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/10] Small improvements to IOV handling Message-ID: <20240502165220.6efcb349@elisabeth> In-Reply-To: <20240501065353.1682358-1-david@gibson.dropbear.id.au> References: <20240501065353.1682358-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BIZ33NE6U6R3462KXRR7HOLNABX3BEG4 X-Message-ID-Hash: BIZ33NE6U6R3462KXRR7HOLNABX3BEG4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 1 May 2024 16:53:43 +1000 David Gibson wrote: > Laurent's changes to split TCP buffers into various components with > IOVs is now merged. This series has a batch of small cleanups to make > the handling of this slightly nicer. These are preliminaries to doing > something similar with the UDP buffers. > > Note that patch 10/10 might interfere with the experiments to work out > what is going wrong with the odd batching / performance issues we've > seen. We can leave it off for the time being if that's a problem. I think it's quick to locally revert for tests if needed. > Changes since v1: > * Added new patch removing some unused structures > * Added two new patches cleaning up some endianness confusion > * Added a bunch of missing cases to standardisation of length > variable names > * Assorted minor revisions based on Stefano's review > > David Gibson (10): > checksum: Use proto_ipv6_header_psum() for ICMPv6 as well > tap: Split tap specific and L2 (ethernet) headers > tap: Remove unused structs tap_msg, tap_l4_msg > treewide: Remove misleading and redundant endianness notes > checksum: Make csum_ip4_header() take a host endian length > treewide: Standardise variable names for various packet lengths > tcp: Simplify packet length calculation when preparing headers > tap, tcp: (Re-)abstract TAP specific header handling > iov: Helper macro to construct iovs covering existing variables or > fields > tcp: Update tap specific header too in tcp_fill_headers[46]() Applied. -- Stefano