* [PATCH] passt.c: explicitly include libgen.h for basename
@ 2024-05-11 15:45 lemmi
2024-05-13 1:36 ` David Gibson
2024-05-13 21:36 ` Stefano Brivio
0 siblings, 2 replies; 3+ messages in thread
From: lemmi @ 2024-05-11 15:45 UTC (permalink / raw)
To: passt-dev
fixes implicit declaration warning on musl
Signed-off-by: lemmi <lemmi@nerd2nerd.org>
---
passt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/passt.c b/passt.c
index e93b6be..771b8a7 100644
--- a/passt.c
+++ b/passt.c
@@ -35,6 +35,7 @@
#include <syslog.h>
#include <sys/prctl.h>
#include <netinet/if_ether.h>
+#include <libgen.h>
#ifdef HAS_GETRANDOM
#include <sys/random.h>
#endif
--
@@ -35,6 +35,7 @@
#include <syslog.h>
#include <sys/prctl.h>
#include <netinet/if_ether.h>
+#include <libgen.h>
#ifdef HAS_GETRANDOM
#include <sys/random.h>
#endif
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] passt.c: explicitly include libgen.h for basename
2024-05-11 15:45 [PATCH] passt.c: explicitly include libgen.h for basename lemmi
@ 2024-05-13 1:36 ` David Gibson
2024-05-13 21:36 ` Stefano Brivio
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2024-05-13 1:36 UTC (permalink / raw)
To: lemmi; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Sat, May 11, 2024 at 05:45:42PM +0200, lemmi wrote:
> fixes implicit declaration warning on musl
>
> Signed-off-by: lemmi <lemmi@nerd2nerd.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/passt.c b/passt.c
> index e93b6be..771b8a7 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -35,6 +35,7 @@
> #include <syslog.h>
> #include <sys/prctl.h>
> #include <netinet/if_ether.h>
> +#include <libgen.h>
> #ifdef HAS_GETRANDOM
> #include <sys/random.h>
> #endif
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] passt.c: explicitly include libgen.h for basename
2024-05-11 15:45 [PATCH] passt.c: explicitly include libgen.h for basename lemmi
2024-05-13 1:36 ` David Gibson
@ 2024-05-13 21:36 ` Stefano Brivio
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2024-05-13 21:36 UTC (permalink / raw)
To: lemmi; +Cc: passt-dev
On Sat, 11 May 2024 17:45:42 +0200
lemmi <lemmi@nerd2nerd.org> wrote:
> fixes implicit declaration warning on musl
>
> Signed-off-by: lemmi <lemmi@nerd2nerd.org>
Applied, thanks, and notified Chimera Linux maintainers that they can
drop their patch too:
https://github.com/chimera-linux/cports/blob/master/contrib/passt/patches/basename.patch
at the next release.
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-13 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-11 15:45 [PATCH] passt.c: explicitly include libgen.h for basename lemmi
2024-05-13 1:36 ` David Gibson
2024-05-13 21:36 ` Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).