From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 21B155A02C7 for ; Mon, 13 May 2024 20:09:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715623765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zbh2Zeue+RDrRv9XJsraLdLgl9UCNANglRYYT2bXos=; b=PLWgITIoFjoAsraFTna69Y8k5/dd9A8vr8IEIhEnO5N7AZuIFMTUM6c2P5hENT0rRHwEsr AU85l53ll+FImMCnrL4cwn8+9N1CfO0fjC5ipPoIfUYAJlP+caGx5Vl021VRKqdRZ0UPJK Qpjl0socbGY8Rxsxdff4bCx4mPFj17E= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-4L4oJYjLPGupc-w__hQdVQ-1; Mon, 13 May 2024 14:08:20 -0400 X-MC-Unique: 4L4oJYjLPGupc-w__hQdVQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a5a180153aeso304284366b.3 for ; Mon, 13 May 2024 11:08:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715623698; x=1716228498; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3zbh2Zeue+RDrRv9XJsraLdLgl9UCNANglRYYT2bXos=; b=Z8iI8oXCN/S/g8hK7rJfZZ3EJdWQ7tFdp9orvVUne1uRuYmQtBBeI4sfnAJv7w5tlA wFTTKOz4J3jX61qdktGYWpwM+/exP2watcBBsdHvzhyYpuCi5+J8nVR60UOa6ayHet+T 3b4HooZa/G5NxQpOqQP1M7I3Mw+YT60qB1sXVSatuf9YGs32CSSYDWxrMd5BPzaTNEO3 wmvPo1SLMs4eCYDUK6jC4jdCFLGmgjx/NwTEBuvldXY1TVrSvUt7bzCChOHUfcAMd74m 7/ZfxgncDNKb8jATR+pmMu3yT9IMaInRRw7XBWJ4aqFCIS64K0+ihfgYRgrhDef8KGe6 bcDw== X-Gm-Message-State: AOJu0Yxp/cD+QXNP5LiT7Zz/iyZPowbx5DzsF5osyA8yhtTeayyk5zAS Izy4p3+z3HyeX1LCv3/Xo5p83Uyb69spGk9BifviaVoLrQs2lcyB1GHRyToX/uamV6GoupdJLB6 Bd8de706wH24oxvQ8sEN1eUGG+o81flDsLjuFfAhY6IeHnGQvk7T2ICwr3Nmn X-Received: by 2002:a17:906:6a02:b0:a5a:7c7e:a0d3 with SMTP id a640c23a62f3a-a5a7c7ea16fmr54649066b.44.1715623698321; Mon, 13 May 2024 11:08:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLFt/kToikyrAOyBnr9P6SbP0Ato79APKqtMMgFBPOGkcMu1uvtDGED93f8yszF3aEVUYEfg== X-Received: by 2002:a17:906:6a02:b0:a5a:7c7e:a0d3 with SMTP id a640c23a62f3a-a5a7c7ea16fmr54647866b.44.1715623697848; Mon, 13 May 2024 11:08:17 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b014besm622746266b.161.2024.05.13.11.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2024 11:08:17 -0700 (PDT) Date: Mon, 13 May 2024 20:07:43 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 04/16] tcp: Obtain guest address from flowside Message-ID: <20240513200743.4892b63b@elisabeth> In-Reply-To: <20240503011135.2924437-5-david@gibson.dropbear.id.au> References: <20240503011135.2924437-1-david@gibson.dropbear.id.au> <20240503011135.2924437-5-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3CSVUIZHTOOJGQR7DLL4D3DNVPCN4DVZ X-Message-ID-Hash: 3CSVUIZHTOOJGQR7DLL4D3DNVPCN4DVZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 3 May 2024 11:11:23 +1000 David Gibson wrote: > Currently we always deliver inbound TCP packets to the guest's most > recent observed IP address. This has the odd side effect that if the > guest changes its IP address with active TCP connections we might > deliver packets from old connections to the new address. That won't > work; it will will probably result in an RST from the guest. Worse, s/will will/will/ ...if I recall correctly, that was actually working, as long as we don't swap link-local with global unicast addresses (hence those conditions sprinkled all over the place). But it doesn't matter in any case, this is surely the way forward. -- Stefano