From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com
Subject: Re: [PATCH v3 2/3] tcp: leverage support of SO_PEEK_OFF socket option when available
Date: Tue, 14 May 2024 23:00:23 +0200 [thread overview]
Message-ID: <20240514230023.700164f9@elisabeth> (raw)
In-Reply-To: <eae0373c-7852-d67a-20ed-1b9994a82abc@redhat.com>
On Tue, 14 May 2024 16:06:22 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> [...]
>
> >> + }
> >> + info("SO_PEEK_OFF%ssupported", peek_offset_cap ? " " : " not ");
> > Maintaining the extra newline before the return would be nice.
> There is a reason I prefer printf() when debugging ;-)
No no, I really meant having one newline between info() and the return
0 below, to keep the separation we had before. I wasn't commenting
about the info() itself or about the format.
> I will add it and post a new version shortly.
>
> ///jon
>
> > The
> > changes actually related to SO_PEEK_OFF look good to me otherwise.
> >
> >> return 0;
> >> }
> >>
>
--
Stefano
next prev parent reply other threads:[~2024-05-14 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 15:20 [PATCH v3 0/3] Support for SO_PEEK_OFF socket option Jon Maloy
2024-05-11 15:20 ` [PATCH v3 1/3] tcp: move seq_to_tap update to when frame is queued Jon Maloy
2024-05-13 2:09 ` David Gibson
2024-05-14 16:48 ` Stefano Brivio
2024-05-11 15:20 ` [PATCH v3 2/3] tcp: leverage support of SO_PEEK_OFF socket option when available Jon Maloy
2024-05-13 2:23 ` David Gibson
2024-05-14 17:22 ` Stefano Brivio
2024-05-14 20:06 ` Jon Maloy
2024-05-14 21:00 ` Stefano Brivio [this message]
2024-05-11 15:20 ` [PATCH v3 3/3] tcp: allow retransmit when peer receive window is zero Jon Maloy
2024-05-14 17:46 ` Stefano Brivio
2024-05-14 20:19 ` Jon Maloy
2024-05-14 21:09 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514230023.700164f9@elisabeth \
--to=sbrivio@redhat.com \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).