From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
by passt.top (Postfix) with ESMTP id C27595A02DE
for <passt-dev@passt.top>; Tue, 14 May 2024 23:01:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1715720462;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=MASG43LDtl6X8UDnzuAJ+JzAkVSLBOr0DUep4L7PrTU=;
b=egOd/OHGsYGN3cwf5V/pQn1FbC67IsYJF5FclGMnsYRtlVQBHrI6PUdXNqlCH1NvB4FGrA
dCnpbeoSUZJtT+qEkEN8v9LPAU1TVk95pDC4yF/LiuoRu6cpaLCR6/QHWwCf33V4JVV/fU
yNQna0trezKjHG9ovU0/tJW77bq2oaQ=
Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com
[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-141-ayt2WdK9NDaS79w04i0Vrg-1; Tue, 14 May 2024 17:01:01 -0400
X-MC-Unique: ayt2WdK9NDaS79w04i0Vrg-1
Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a59a5b06802so314132866b.1
for <passt-dev@passt.top>; Tue, 14 May 2024 14:01:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1715720458; x=1716325258;
h=content-transfer-encoding:mime-version:organization:references
:in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=MASG43LDtl6X8UDnzuAJ+JzAkVSLBOr0DUep4L7PrTU=;
b=h587fZ0Y8fxU3qK28wQXXzvAfcqdPWYMnLdTb6YIw2iY9sIkHdaGMp7TedNSo16xUP
cP3Vm3GS/cqsebOj2HGXNkMPgKp5d6mENBPOua4dVjEweJsYeJCH6suzURX/yrgUisXs
kHjPEh27iCulCXIlq0CuSvjHClIGhunfyeWMHVLizwyGcbxEkdXoWzljnn6L295E1A+v
3dW+/XkBOidzljbmGrChU3bqq88LesR09FjHhOo97TFYKtZ3TVibzlAYPJnut++wEWJ9
HuAlQ5p6zSewqS/SnzJAecJBoCnGVTao/+RAoBnw4rrOlfQKztW+h2Rmo4Q3sUHOK7o3
4oVw==
X-Gm-Message-State: AOJu0YzoEjEBJCQaAfNI8CviSh2yNNDL2Prp16LhGrhQazjNs4znz4ax
llYuftpxC3lyGBFhAzkDQd1bLtnOHW/1sc2S44ERfUGxiEGA23LbYZfJb0hs/XafVk6xTA86EEV
TVUK/ppqMNetFyzUORHXYIpB2eR/dOPAjKn7Zk9kgHLNsTR8S9tC04bQM9BOlQCHwNsprLBvFOh
y+l9ruZImmRT6rmiqGhY8LS6BpdAVAocu8fFE=
X-Received: by 2002:a17:906:329b:b0:a5a:896e:d0b4 with SMTP id a640c23a62f3a-a5a896ed17fmr158120966b.26.1715720458506;
Tue, 14 May 2024 14:00:58 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IF/7vdXY2QCX7eR6ulTuqOdVzZBb0vNL5z26NDcg1G5O9H4kv62Shubq7DiHMdE8PkbDNNFeA==
X-Received: by 2002:a17:906:329b:b0:a5a:896e:d0b4 with SMTP id a640c23a62f3a-a5a896ed17fmr158119166b.26.1715720457898;
Tue, 14 May 2024 14:00:57 -0700 (PDT)
Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33])
by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a3c24992dsm605691566b.96.2024.05.14.14.00.56
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 14 May 2024 14:00:57 -0700 (PDT)
Date: Tue, 14 May 2024 23:00:23 +0200
From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Subject: Re: [PATCH v3 2/3] tcp: leverage support of SO_PEEK_OFF socket
option when available
Message-ID: <20240514230023.700164f9@elisabeth>
In-Reply-To: <eae0373c-7852-d67a-20ed-1b9994a82abc@redhat.com>
References: <20240511152008.421750-1-jmaloy@redhat.com>
<20240511152008.421750-3-jmaloy@redhat.com>
<20240514192218.32382aae@elisabeth>
<eae0373c-7852-d67a-20ed-1b9994a82abc@redhat.com>
Organization: Red Hat
X-Mailer: Claws Mail 4.2.0 (GTK 3.24.36; x86_64-pc-linux-gnu)
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID-Hash: 7KLPZ5YLSHXWG7JXJQEGETZ2AIQQJ3R6
X-Message-ID-Hash: 7KLPZ5YLSHXWG7JXJQEGETZ2AIQQJ3R6
X-MailFrom: sbrivio@redhat.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20240514230023.700164f9@elisabeth/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/7KLPZ5YLSHXWG7JXJQEGETZ2AIQQJ3R6/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>
On Tue, 14 May 2024 16:06:22 -0400
Jon Maloy <jmaloy@redhat.com> wrote:
> [...]
>
> >> + }
> >> + info("SO_PEEK_OFF%ssupported", peek_offset_cap ? " " : " not ");
> > Maintaining the extra newline before the return would be nice.
> There is a reason I prefer printf() when debugging ;-)
No no, I really meant having one newline between info() and the return
0 below, to keep the separation we had before. I wasn't commenting
about the info() itself or about the format.
> I will add it and post a new version shortly.
>
> ///jon
>
> > The
> > changes actually related to SO_PEEK_OFF look good to me otherwise.
> >
> >> return 0;
> >> }
> >>
>
--
Stefano