Re: [PATCH] apparmor: Fix passt abstraction

[Stefano Brivio <sbrivio@redhat.com>]

Hi Maxime,

On Fri, 17 May 2024 13:50:54 +0200
Maxime Bélair <maxime.belair@canonical.com> wrote:

> Commit b686afa2 introduced the invalid apparmor rule `mount options=(rw, runbindable) /,` since runbindable mount rules cannot have a source.

Oops, right, I didn't actually drop the source specification there. :(
Thanks for fixing this.

> Therefore running aa-logprof/aa-genprof will trigger errors (see https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2065685)
> 
>     $ sudo aa-logprof
>     ERROR: Operation {'runbindable'} cannot have a source. Source = AARE('/')

I wonder why I don't see this on Debian testing with AppArmor 3.0.13
(same on openSUSE Tumbleweed).

Is there something in particular I should do to reproduce/check this?

> This patch fixes it to the intended behavior.
> 
> Signed-off-by: Maxime Bélair <maxime.belair@canonical.com>
> ---
>  contrib/apparmor/abstractions/passt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/apparmor/abstractions/passt b/contrib/apparmor/abstractions/passt
> index 61ec32c..d245115 100644
> --- a/contrib/apparmor/abstractions/passt
> +++ b/contrib/apparmor/abstractions/passt
> @@ -26,7 +26,7 @@
>    capability sys_ptrace,
>  
>    /					r,	# isolate_prefork(), isolation.c
> -  mount options=(rw, runbindable) /,
> +  mount options=(rw, runbindable) -> /,
>    mount		""	-> "/",
>    mount		""	-> "/tmp/",
>    pivot_root	"/tmp/" -> "/tmp/",

-- 
Stefano