From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E97CD5A0304 for ; Fri, 17 May 2024 14:28:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715948894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4WET6sI8/rpV/tFPlyEbvmfCni4NOmJq+1IE8nkgUWU=; b=hvnGeQ/TDDK4xHOBBvTculfR1WWtLrwOuTN5Bg0z2x27jp+of1JAjPDFPxwH06INcDnSuo riOR5bhmAHuExKDoquJ3eG2BuXJCNg1DbHoRdNtxhR49KKAuSel/0bfe/ST7m2haHJscei 2n+Pwyd4mgkv84kdB8j3s7KLadW213I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-kTeNefv4MMGzSjMwEk83yg-1; Fri, 17 May 2024 08:28:13 -0400 X-MC-Unique: kTeNefv4MMGzSjMwEk83yg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 083228030A5; Fri, 17 May 2024 12:28:13 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3779F2026D6E; Fri, 17 May 2024 12:28:12 +0000 (UTC) Date: Fri, 17 May 2024 14:28:09 +0200 From: Stefano Brivio To: Maxime =?UTF-8?B?QsOpbGFpcg==?= Subject: Re: [PATCH] apparmor: Fix passt abstraction Message-ID: <20240517142809.265e69f3@elisabeth> In-Reply-To: <20240517115053.53072-1-maxime.belair@canonical.com> References: <20240517115053.53072-1-maxime.belair@canonical.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 54ID36XVDCDVA6JHNYS4DCVP4RAQME2P X-Message-ID-Hash: 54ID36XVDCDVA6JHNYS4DCVP4RAQME2P X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Maxime, On Fri, 17 May 2024 13:50:54 +0200 Maxime B=C3=A9lair wrote: > Commit b686afa2 introduced the invalid apparmor rule `mount options=3D(rw= , runbindable) /,` since runbindable mount rules cannot have a source. Oops, right, I didn't actually drop the source specification there. :( Thanks for fixing this. > Therefore running aa-logprof/aa-genprof will trigger errors (see https://= bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2065685) >=20 > $ sudo aa-logprof > ERROR: Operation {'runbindable'} cannot have a source. Source =3D AAR= E('/') I wonder why I don't see this on Debian testing with AppArmor 3.0.13 (same on openSUSE Tumbleweed). Is there something in particular I should do to reproduce/check this? > This patch fixes it to the intended behavior. >=20 > Signed-off-by: Maxime B=C3=A9lair > --- > contrib/apparmor/abstractions/passt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/contrib/apparmor/abstractions/passt b/contrib/apparmor/abstr= actions/passt > index 61ec32c..d245115 100644 > --- a/contrib/apparmor/abstractions/passt > +++ b/contrib/apparmor/abstractions/passt > @@ -26,7 +26,7 @@ > capability sys_ptrace, > =20 > /=09=09=09=09=09r,=09# isolate_prefork(), isolation.c > - mount options=3D(rw, runbindable) /, > + mount options=3D(rw, runbindable) -> /, > mount=09=09""=09-> "/", > mount=09=09""=09-> "/tmp/", > pivot_root=09"/tmp/" -> "/tmp/", --=20 Stefano