public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Danish Prakash <contact@danishpraka.sh>
To: sbrivio@redhat.com, passt-dev@passt.top
Cc: Danish Prakash <contact@danishpraka.sh>
Subject: [PATCH] pasta.c: modify hostname when detaching new namespace
Date: Mon, 20 May 2024 14:05:58 +0530	[thread overview]
Message-ID: <20240520083650.12032-1-contact@danishpraka.sh> (raw)

When invoking pasta without any arguments, it's difficult
to tell whether we are in the new namespace or not leaving
users a bit confused. This change modifies the host namespace
to add a prefix "pasta-" to make it a bit more obvious.

Signed-off-by: Danish Prakash <contact@danishpraka.sh>
---
 pasta.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/pasta.c b/pasta.c
index 31e1e00..840a2b1 100644
--- a/pasta.c
+++ b/pasta.c
@@ -180,6 +180,8 @@ static int pasta_spawn_cmd(void *arg)
 {
 	const struct pasta_spawn_cmd_arg *a;
 	sigset_t set;
+	char hostname[HOST_NAME_MAX+1], pasta_hostname[HOST_NAME_MAX+1];
+	char *hostname_prefix = "pasta-";
 
 	/* We run in a detached PID and mount namespace: mount /proc over */
 	if (mount("", "/proc", "proc", 0, NULL))
@@ -188,6 +190,17 @@ static int pasta_spawn_cmd(void *arg)
 	if (write_file("/proc/sys/net/ipv4/ping_group_range", "0 0"))
 		warn("Cannot set ping_group_range, ICMP requests might fail");
 
+	if (gethostname(hostname, HOST_NAME_MAX+1) == 0) {
+		if ((strlen(hostname) + strlen(hostname_prefix)) > HOST_NAME_MAX) {
+			hostname[strlen(hostname)-strlen(hostname_prefix)] = '\0';
+		}
+		sprintf(pasta_hostname, "%s%s", hostname_prefix, hostname);
+
+		if (sethostname(pasta_hostname, strlen(pasta_hostname)) != 0) {
+			warn("Unable to set pasta-prefixed hostname");
+		}
+	}
+
 	/* Wait for the parent to be ready: see main() */
 	sigemptyset(&set);
 	sigaddset(&set, SIGUSR1);
-- 
@@ -180,6 +180,8 @@ static int pasta_spawn_cmd(void *arg)
 {
 	const struct pasta_spawn_cmd_arg *a;
 	sigset_t set;
+	char hostname[HOST_NAME_MAX+1], pasta_hostname[HOST_NAME_MAX+1];
+	char *hostname_prefix = "pasta-";
 
 	/* We run in a detached PID and mount namespace: mount /proc over */
 	if (mount("", "/proc", "proc", 0, NULL))
@@ -188,6 +190,17 @@ static int pasta_spawn_cmd(void *arg)
 	if (write_file("/proc/sys/net/ipv4/ping_group_range", "0 0"))
 		warn("Cannot set ping_group_range, ICMP requests might fail");
 
+	if (gethostname(hostname, HOST_NAME_MAX+1) == 0) {
+		if ((strlen(hostname) + strlen(hostname_prefix)) > HOST_NAME_MAX) {
+			hostname[strlen(hostname)-strlen(hostname_prefix)] = '\0';
+		}
+		sprintf(pasta_hostname, "%s%s", hostname_prefix, hostname);
+
+		if (sethostname(pasta_hostname, strlen(pasta_hostname)) != 0) {
+			warn("Unable to set pasta-prefixed hostname");
+		}
+	}
+
 	/* Wait for the parent to be ready: see main() */
 	sigemptyset(&set);
 	sigaddset(&set, SIGUSR1);
-- 
2.45.1



             reply	other threads:[~2024-05-20  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  8:35 Danish Prakash [this message]
     [not found] ` <20240521193400.4f1b15c5@elisabeth>
2024-05-23 13:52   ` [PATCH] pasta.c: modify hostname when detaching new namespace Danish Prakash
2024-05-23 14:23     ` Stefano Brivio
2024-05-24 12:45       ` Danish Prakash
2024-05-24 17:38         ` Stefano Brivio
2024-05-24 12:48 ` Danish Prakash
2024-05-24 17:39   ` Stefano Brivio
2024-06-25 22:27     ` Stefano Brivio
2024-07-29 13:56     ` Danish Prakash
2024-07-29 17:54       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520083650.12032-1-contact@danishpraka.sh \
    --to=contact@danishpraka.sh \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).