From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 947E85A0307 for ; Wed, 29 May 2024 11:04:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1716973448; bh=Pg73XssR3qREyFnWRZz2f2G4C8u2PztmxXKvlbH9wsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JdBAOtV7V13ENrVr1e1E+EwA04u0wIjYRYAwcN4PnptLewXJ5Z+/iARud8TGUxqIQ yoIyOJroCzHCeSBI5B5GvlFuHuAEV9+esJW/SJJng74c9i8CmtiL+nS5XYzy/FAyDu rX1cztQR+W93NX0Hh+OnkhHyiS1T+KTChccInnPnooVxzjWPvtZJwzJKc8N+pn/JpN 7gGBlEdm4bhawIIgSIV6yC8OGiTQiarwIJ/d6Vt12rP5jfN2DPlPzTqzA16yghNaRf 2u/DUjsDKZSsDj38J/mgYMYQGK9Zb20OFtdlafCjTfcq9BawIiSkcNj9CNAzraHEfS P44Gh/sdzCADw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Vq3N84Lltz4wbh; Wed, 29 May 2024 19:04:08 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/3] conf: Remove unhelpful usage() wrapper Date: Wed, 29 May 2024 19:04:03 +1000 Message-ID: <20240529090405.965748-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240529090405.965748-1-david@gibson.dropbear.id.au> References: <20240529090405.965748-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 6HGX5ICULQB67C7ZOVDR4TM7N427BHVJ X-Message-ID-Hash: 6HGX5ICULQB67C7ZOVDR4TM7N427BHVJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: erik.sjolund@gmail.com, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: usage() does nothing but call print_usage() with EXIT_FAILURE as a parameter. It's no more complex to just give that parameter at the single call site. Eliminate it and rename print_usage() to just usage(). Signed-off-by: David Gibson --- conf.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/conf.c b/conf.c index 50383a39..f2a92574 100644 --- a/conf.c +++ b/conf.c @@ -704,11 +704,11 @@ static unsigned int conf_ip6(unsigned int ifi, } /** - * print_usage() - Print usage, exit with given status code + * usage() - Print usage, exit with given status code * @name: Executable name * @status: Status code for exit() */ -static void print_usage(const char *name, int status) +static void usage(const char *name, int status) { if (strstr(name, "pasta")) { info("Usage: %s [OPTION]... [COMMAND] [ARGS]...", name); @@ -897,15 +897,6 @@ pasta_opts: exit(status); } -/** - * usage() - Print usage and exit with failure - * @name: Executable name - */ -static void usage(const char *name) -{ - print_usage(name, EXIT_FAILURE); -} - /** * conf_print() - Print fundamental configuration parameters * @c: Execution context @@ -1647,11 +1638,11 @@ void conf(struct ctx *c, int argc, char **argv) break; case 'h': log_to_stdout = 1; - print_usage(argv[0], EXIT_SUCCESS); + usage(argv[0], EXIT_SUCCESS); break; case '?': default: - usage(argv[0]); + usage(argv[0], EXIT_FAILURE); break; } } while (name != -1); -- 2.45.1