From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v3 03/11] tcp: extract buffer management from tcp_conn_tap_mss()
Date: Wed, 29 May 2024 12:19:01 +0200 [thread overview]
Message-ID: <20240529101909.1120078-4-lvivier@redhat.com> (raw)
In-Reply-To: <20240529101909.1120078-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tcp.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tcp.c b/tcp.c
index a6f43010f58f..c274ea6c4ca4 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1804,6 +1804,14 @@ static int tcp_conn_new_sock(const struct ctx *c, sa_family_t af)
return s;
}
+static uint16_t tcp_buf_conn_tap_mss(const struct tcp_tap_conn *conn)
+{
+ if (CONN_V4(conn))
+ return MSS4;
+
+ return MSS6;
+}
+
/**
* tcp_conn_sock() - Obtain a connectable socket in the host/init namespace
* @c: Execution context
@@ -1849,10 +1857,7 @@ static uint16_t tcp_conn_tap_mss(const struct tcp_tap_conn *conn,
else
mss = ret;
- if (CONN_V4(conn))
- mss = MIN(MSS4, mss);
- else
- mss = MIN(MSS6, mss);
+ mss = MIN(tcp_buf_conn_tap_mss(conn), mss);
return MIN(mss, USHRT_MAX);
}
--
@@ -1804,6 +1804,14 @@ static int tcp_conn_new_sock(const struct ctx *c, sa_family_t af)
return s;
}
+static uint16_t tcp_buf_conn_tap_mss(const struct tcp_tap_conn *conn)
+{
+ if (CONN_V4(conn))
+ return MSS4;
+
+ return MSS6;
+}
+
/**
* tcp_conn_sock() - Obtain a connectable socket in the host/init namespace
* @c: Execution context
@@ -1849,10 +1857,7 @@ static uint16_t tcp_conn_tap_mss(const struct tcp_tap_conn *conn,
else
mss = ret;
- if (CONN_V4(conn))
- mss = MIN(MSS4, mss);
- else
- mss = MIN(MSS6, mss);
+ mss = MIN(tcp_buf_conn_tap_mss(conn), mss);
return MIN(mss, USHRT_MAX);
}
--
2.44.0
next prev parent reply other threads:[~2024-05-29 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 10:18 [PATCH v3 00/11] Add vhost-user support to passt (part 2) Laurent Vivier
2024-05-29 10:18 ` [PATCH v3 01/11] tcp: inline tcp_l2_buf_fill_headers() Laurent Vivier
2024-05-31 5:22 ` David Gibson
2024-05-29 10:19 ` [PATCH v3 02/11] tcp: extract buffer management from tcp_send_flag() Laurent Vivier
2024-05-29 10:19 ` Laurent Vivier [this message]
2024-05-29 10:19 ` [PATCH v3 04/11] tcp: move buffers management functions to their own file Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 05/11] tap: export pool_flush()/tapX_handler()/packet_add() Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 06/11] udp: move udpX_l2_buf_t and udpX_l2_mh_sock out of udp_update_hdrX() Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 07/11] udp: rename udp_sock_handler() to udp_buf_sock_handler() Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 08/11] vhost-user: compare mode MODE_PASTA and not MODE_PASST Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 09/11] iov: remove iov_copy() Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 10/11] tcp: remove tap_hdr parameter Laurent Vivier
2024-05-29 10:19 ` [PATCH v3 11/11] tap: use in->buf_size rather than sizeof(pkt_buf) Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529101909.1120078-4-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).