From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, erik.sjolund@gmail.com
Subject: Re: [PATCH v2 0/3] conf, log: Fix regression in usage() printing
Date: Wed, 5 Jun 2024 21:59:12 +0200 [thread overview]
Message-ID: <20240605215912.60f52476@elisabeth> (raw)
In-Reply-To: <20240605004243.3330116-1-david@gibson.dropbear.id.au>
On Wed, 5 Jun 2024 10:42:39 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> Erik Sjölund pointed out a regression where we're no long printing the
> --help message to stdout, but to stderr instead.
>
> I'm not actually sure what caused the regression, but it was made
> possible by the fact that the original fix was pretty strange to begin
> with. It introduced some hacks to force the logging subsystem to go
> to stdout, which have presumably failed in some subtle way. But,
> there's really no reason to run usage() through the logging subsystem
> in the first place - it just adds complexity.
>
> Link: https://bugs.passt.top/show_bug.cgi?id=90
> Link: https://bugs.passt.top/show_bug.cgi?id=52
>
> Changes since v1:
> * Use multi-line strings heavily in 2/3
>
> David Gibson (3):
> conf: Remove unhelpful usage() wrapper
> conf: Don't print usage via the logging subsystem
> log: Remove log_to_stdout option
Applied.
--
Stefano
prev parent reply other threads:[~2024-06-05 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 0:42 [PATCH v2 0/3] conf, log: Fix regression in usage() printing David Gibson
2024-06-05 0:42 ` [PATCH v2 1/3] conf: Remove unhelpful usage() wrapper David Gibson
2024-06-05 0:42 ` [PATCH v2 2/3] conf: Don't print usage via the logging subsystem David Gibson
2024-06-05 0:42 ` [PATCH v2 3/3] log: Remove log_to_stdout option David Gibson
2024-06-05 19:59 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605215912.60f52476@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=erik.sjolund@gmail.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).