From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E12F05A0050 for ; Thu, 06 Jun 2024 00:13:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717625592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYutEKRXGld66J0wB85Fwx6NVMqFnhnhf3MZN2k/BoY=; b=C+CecUZj1d1NhWvPR8KmRYgwh2dvUD+WSNFoLdPBDc0B8Ss0pf8QKGnMpPDy+JECQ175cz C/knvj3EwzNGQviTr/Y5jkECz41fIiX5LlupzA9aKwSOk9O8drbfHxdXtshxP6FmcRk5st 9DiNBPOBMH0M8yHHBjt7M8rzJZTYahQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-ncYGfyZ-M2aoA4pjFJfF2g-1; Wed, 05 Jun 2024 15:59:52 -0400 X-MC-Unique: ncYGfyZ-M2aoA4pjFJfF2g-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7952f541411so38355185a.1 for ; Wed, 05 Jun 2024 12:59:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717617592; x=1718222392; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vYutEKRXGld66J0wB85Fwx6NVMqFnhnhf3MZN2k/BoY=; b=SEZ+X9dFxcnoII2XqRUc5/G3/fAPykoRYBE50LeCq3tkBucK9lRNzIkCmCldDIYBqF T7+okxeFkmL4+OcWTu+Ff5j33Obj4FHa1dJyt5gukUiUiegB0zyGoIkEGUl7xywkOfV2 julkszCHJu4/U9RNf6VAZ0TL62uhFpC5tKYUSyTYUeULDanyIT8SgAOmIETeFPF13ET8 NLI0ZWAcdsleufOlKMu+QrAKHudgpYsFOgfe6W2hMZtWryNg2JBtN8sF/3rWArsaDLyp BslMAQq78uXpnXlmC97ZleQnJtGBlVgVm4BVMp6wlm/60SNmCmOl2UMhYi2C28G+JWAt CS3A== X-Gm-Message-State: AOJu0Yw6xwoengCZqM1aGlOLYW7ju4M+FcggAVK4TijduOBRj9LjlDSC M2fLCPq9FQ9/Giy0ckhD9srBkPDr8Z6Due2S0NRGJXDUcOr/+aQf+HKRoB82xSvz5OQ4BbolCHH TSVL6g+TYWu8qwjmyyGHHc6ErJ+J1yiugvrfoGpusyCMYKE/qHQ== X-Received: by 2002:a05:620a:2448:b0:795:1e65:933d with SMTP id af79cd13be357-7952f0ddfebmr136526685a.13.1717617591328; Wed, 05 Jun 2024 12:59:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdYg+ENpT44pDouKaHgFXWloSQ1UqFqT5IROm7u+AfXxl/NmJCG4mtYhMZSnqoTqkNS5HY1A== X-Received: by 2002:a05:620a:2448:b0:795:1e65:933d with SMTP id af79cd13be357-7952f0ddfebmr136521385a.13.1717617590730; Wed, 05 Jun 2024 12:59:50 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id af79cd13be357-794f3177350sm469638785a.124.2024.06.05.12.59.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2024 12:59:49 -0700 (PDT) Date: Wed, 5 Jun 2024 21:59:12 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/3] conf, log: Fix regression in usage() printing Message-ID: <20240605215912.60f52476@elisabeth> In-Reply-To: <20240605004243.3330116-1-david@gibson.dropbear.id.au> References: <20240605004243.3330116-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BZ5KWSONSPJNVHLEYJ4AQXERTL2PO3TH X-Message-ID-Hash: BZ5KWSONSPJNVHLEYJ4AQXERTL2PO3TH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, erik.sjolund@gmail.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 5 Jun 2024 10:42:39 +1000 David Gibson wrote: > Erik Sj=C3=B6lund pointed out a regression where we're no long printing t= he > --help message to stdout, but to stderr instead. >=20 > I'm not actually sure what caused the regression, but it was made > possible by the fact that the original fix was pretty strange to begin > with. It introduced some hacks to force the logging subsystem to go > to stdout, which have presumably failed in some subtle way. But, > there's really no reason to run usage() through the logging subsystem > in the first place - it just adds complexity. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D90 > Link: https://bugs.passt.top/show_bug.cgi?id=3D52 >=20 > Changes since v1: > * Use multi-line strings heavily in 2/3 >=20 > David Gibson (3): > conf: Remove unhelpful usage() wrapper > conf: Don't print usage via the logging subsystem > log: Remove log_to_stdout option Applied. --=20 Stefano