From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/9] Some more static checker fixes
Date: Thu, 6 Jun 2024 20:09:40 +1000 [thread overview]
Message-ID: <20240606100949.1250958-1-david@gibson.dropbear.id.au> (raw)
This series includes a number of fixes related to the static checkers:
* Fedora 40 has updated to Cppcheck 2.14.1 which introduces some new
warnings. Fix them.
* Jon's recent patch caused a small cppcheck regression. I assume
neither Jon nor Stefano is using sufficiently recent cppcheck
versions to catch it. Fix that too.
* We were disabling the bugprone-macro parentheses check in
clang-tidy. I don't think that's a good idea. Re-enable it and
fix existing warnings.
* It might also be a good idea to enable the
bugprone-narrowing-conversions check. Fix a number of issues
across the tree which, amongst other things trigger that warning.
There are lots of other places that trigger the warning which I
haven't fixed yet, so don't enable it yet.
David Gibson (9):
tcp: Make pointer const in tcp_revert_seq
udp: Make rport calculation more local
cppcheck: Suppress constParameterCallback errors
Remove pointless macro parameters in CALL_PROTO_HANDLER
clang-tidy: Enable the bugprone-macro-parentheses check
util: Use unsigned indices for bits in bitmaps
conf: Safer parsing of MAC addresses
lineread: Use ssize_t for line lengths
util: Use 'long' to represent millisecond durations
Makefile | 3 +--
conf.c | 55 +++++++++++++++++++++++++++++++++++-----------------
lineread.c | 10 ++++------
lineread.h | 7 ++++---
passt.c | 6 +++---
tap.c | 37 ++++++++++++++++++-----------------
tcp.c | 10 +++++-----
tcp_splice.c | 4 ++--
udp.c | 3 +--
util.c | 10 +++++-----
util.h | 8 ++++----
11 files changed, 85 insertions(+), 68 deletions(-)
--
2.45.2
next reply other threads:[~2024-06-06 10:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 10:09 David Gibson [this message]
2024-06-06 10:09 ` [PATCH 1/9] tcp: Make pointer const in tcp_revert_seq David Gibson
2024-06-06 10:09 ` [PATCH 2/9] udp: Make rport calculation more local David Gibson
2024-06-06 10:09 ` [PATCH 3/9] cppcheck: Suppress constParameterCallback errors David Gibson
2024-06-07 18:49 ` Stefano Brivio
2024-06-08 6:32 ` David Gibson
2024-06-08 11:48 ` Stefano Brivio
2024-06-06 10:09 ` [PATCH 4/9] Remove pointless macro parameters in CALL_PROTO_HANDLER David Gibson
2024-06-06 10:09 ` [PATCH 5/9] clang-tidy: Enable the bugprone-macro-parentheses check David Gibson
2024-06-06 10:09 ` [PATCH 6/9] util: Use unsigned indices for bits in bitmaps David Gibson
2024-06-06 10:09 ` [PATCH 7/9] conf: Safer parsing of MAC addresses David Gibson
2024-06-06 10:09 ` [PATCH 8/9] lineread: Use ssize_t for line lengths David Gibson
2024-06-06 10:09 ` [PATCH 9/9] util: Use 'long' to represent millisecond durations David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606100949.1250958-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).