[PATCH 3/9] cppcheck: Suppress constParameterCallback errors

[David Gibson <david@gibson.dropbear.id.au>]

We have several functions which are used as callbacks for NS_CALL() which
only read their void * parameter, they don't write it.  The new
constParameterCallback warning in cppcheck 2.14.1 complains that this
parameter could be const void *, also pointing out that that would require
casting the function pointer when used as a callback.

Casting the function pointers seems substantially uglier than using a
non-const void * as the parameter, especially since in each case we cast
the void * to a const pointer of specific type immediately.  So, suppress
that error from cppcheck.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 8ea17576..22f05813 100644
--- a/Makefile
+++ b/Makefile
@@ -314,5 +314,6 @@ cppcheck: $(SRCS) $(HEADERS)
 	$(SYSTEM_INCLUDES:%=--suppress=unmatchedSuppression:%/*)	\
 	--inline-suppr							\
 	--suppress=unusedStructMember					\
+	--suppress=constParameterCallback				\
 	$(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS))			\
 	$(SRCS) $(HEADERS)
-- 
@@ -314,5 +314,6 @@ cppcheck: $(SRCS) $(HEADERS)
 	$(SYSTEM_INCLUDES:%=--suppress=unmatchedSuppression:%/*)	\
 	--inline-suppr							\
 	--suppress=unusedStructMember					\
+	--suppress=constParameterCallback				\
 	$(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS))			\
 	$(SRCS) $(HEADERS)
-- 
2.45.2