From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id B7EA65A004F for ; Sat, 08 Jun 2024 08:30:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1717828243; bh=3omOxKlIXNQ3n+jR4OAytbehq0xqNQw6N290/2ZEAWU=; h=From:To:Cc:Subject:Date:From; b=bYOfiiPgm95o8CFWyvTGFkNyb/M7SV0TrAKqYdjrqwazwlhZDiIdrK8aY/lUP7UjB aV+G7zIcrc1N5vn8dgNuEFMUk9T2lZyK2c70DJuNAwlPV0NE6bQWXDvMgTas+Lo+GI 192EOv3XXGU+YxaUrEPrCYLc0RAExCkzHplH/VPL6kJpyV1Xkld8OC+7TqsWlQHDl6 w87M7b8HMuuqTb5oGo1yQxnJGbFENlVsHxvS2gsfPwp0cdlsPcmuXbcd88eTQqO23t 1cP1S97UZ6kleo0/dzLT+5JBNY1oJAimhHDUrhxHUIWKM20mUEOdGChgDWGarwZSJS KXogQQrO96Lag== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Vx7VW74mmz4wyQ; Sat, 8 Jun 2024 16:30:43 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 0/1] Some more static checker fixes Date: Sat, 8 Jun 2024 16:30:39 +1000 Message-ID: <20240608063040.1835930-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.45.2 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: FGXAAJ7W37NZGV6FH6BWJXKOLM3D6PQV X-Message-ID-Hash: FGXAAJ7W37NZGV6FH6BWJXKOLM3D6PQV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This series includes a number of fixes related to the static checkers: * Fedora 40 has updated to Cppcheck 2.14.1 which introduces some new warnings. Fix them. * Jon's recent patch caused a small cppcheck regression. I assume neither Jon nor Stefano is using sufficiently recent cppcheck versions to catch it. Fix that too. * We were disabling the bugprone-macro parentheses check in clang-tidy. I don't think that's a good idea. Re-enable it and fix existing warnings. * It might also be a good idea to enable the bugprone-narrowing-conversions check. Fix a number of issues across the tree which, amongst other things trigger that warning. There are lots of other places that trigger the warning which I haven't fixed yet, so don't enable it yet. Changes since v2: * Rebased after most of the series was applied * Avoid triggering unmatchedSuppression on earlier cppcheck versions David Gibson (1): cppcheck: Suppress constParameterCallback errors pasta.c | 1 + tcp.c | 1 + tcp_splice.c | 1 + 3 files changed, 3 insertions(+) -- 2.45.2