Re: [PATCH v5 2/8] tcp: move buffers management functions to their own file

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 12 Jun 2024 16:14:38 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Jun 05, 2024 at 05:21:23PM +0200, Laurent Vivier wrote:
> > Move all the TCP parts using internal buffers to tcp_buf.c
> > and keep generic TCP management functions in tcp.c.
> > Add tcp_internal.h to export needed functions from tcp.c and
> > tcp_buf.h from tcp_buf.c
> > 
> > With this change we can use existing TCP functions with a
> > different kind of memory storage as for instance the shared
> > memory provided by the guest via vhost-user.
> > 
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>  
> 
> Basically just code motion, so a kind of trivial
> 
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
> Of course, this will conflict with basically any change in tcp.c.
> Stefano, I wonder if it's worth going ahead and merging this soon, so
> neither Laurent nor I needs to keep rebasing.

I think we're quite close to merge the whole series once Laurent
addresses pending comments... I'll try to be quick once it happens.

-- 
Stefano