From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 98C6B5A004F for ; Wed, 12 Jun 2024 14:04:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718193861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/w+wzmXNe/7XJvYUh5Yk7I/g9t4sNfOUpbM9cvQris=; b=Pk/smkaqdFYUvbCWahIYwA/KV8HtHWAMFBDJpGBta6borzA3DpjoS8yyDhmh7kUGZiAc2q X16cNJ/75BmSSkbAKXDIzS9p1tZHaipCOGr2fgHcJlnQO09mnfjeiGuLHPgtiysw/uC+m/ YpIdJTTweO1C30i3iCSUrbz07gZL834= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-kx1dTmcTPSC1kno14Syo2g-1; Wed, 12 Jun 2024 08:04:20 -0400 X-MC-Unique: kx1dTmcTPSC1kno14Syo2g-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b0665d2f9cso53073136d6.1 for ; Wed, 12 Jun 2024 05:04:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718193859; x=1718798659; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=M/w+wzmXNe/7XJvYUh5Yk7I/g9t4sNfOUpbM9cvQris=; b=WjJGnUb7vjpg72C1juCbhLU3N9PhodDq/T+LQuvIVBSoSbeHo5J69GB/CIv0gtFrJw A4KdcS/oKphEnVi//g37wQ9UmuaTni29Mts3/v5HmeHAGWf1raFMU7dv+F5o1wV11Dh2 ywPnhCvdIj2hD3Wx/Pq9L3Gn2cy4tv/TDsMMCZLvgumd1QQBl1/H5WweBiYQa1BDfk+7 49qgVE0Dx/2UNLxfWLU64t2p3T//FTRvV3DkXrmgqgZogPf4i8OIEREEo8kKzqEwhqa2 8PBk5+6eY/Eiuc9Brj0YMoDmZjY6aq3XRPmoehRyeemgHKB5wPD15gdE/k70fOvSPkEv 8QVQ== X-Forwarded-Encrypted: i=1; AJvYcCURa0WW6r2aZJJJq5k9IXKkU6LhvG5R8sqaJ4hBNBhevc6MWsYbIWkFgwJY9tAesq8vF2PE04kXJo4/4QTuJBdab71i X-Gm-Message-State: AOJu0YxRAYzY289EhiJZQ94bnn32F5LVg7rhQhgXuU2mOdLhw+WwPA6R Rh8b77oUKuZAUsZRgH9ndmXupZzhPKeYkDzY0IabM7vprQfhISN2TTbPUJEf1lpCZ5sODCYkxZF uwpV8Cd/YvTbBuicUBLtdlyAfefh3BE9FJtEFMVCVqYi891rhog== X-Received: by 2002:a05:6214:4606:b0:6b0:77fb:8f16 with SMTP id 6a1803df08f44-6b191778bdbmr15451476d6.21.1718193859301; Wed, 12 Jun 2024 05:04:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGr0vVTMKsssq+WSJirJjsVOfmVkCTf6H+XS7oe+qEy5/flWoeQveM3BxMTR5GuczSC3+3BA== X-Received: by 2002:a05:6214:4606:b0:6b0:77fb:8f16 with SMTP id 6a1803df08f44-6b191778bdbmr15450876d6.21.1718193858291; Wed, 12 Jun 2024 05:04:18 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b080015e39sm28588866d6.31.2024.06.12.05.04.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 05:04:17 -0700 (PDT) Date: Wed, 12 Jun 2024 14:03:22 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v5 2/8] tcp: move buffers management functions to their own file Message-ID: <20240612140322.5ac3f8d9@elisabeth> In-Reply-To: References: <20240605152129.1641658-1-lvivier@redhat.com> <20240605152129.1641658-3-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: O5CRD55GXI4LPRDQOTJ3WORP6KT6MQ35 X-Message-ID-Hash: O5CRD55GXI4LPRDQOTJ3WORP6KT6MQ35 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 16:14:38 +1000 David Gibson wrote: > On Wed, Jun 05, 2024 at 05:21:23PM +0200, Laurent Vivier wrote: > > Move all the TCP parts using internal buffers to tcp_buf.c > > and keep generic TCP management functions in tcp.c. > > Add tcp_internal.h to export needed functions from tcp.c and > > tcp_buf.h from tcp_buf.c > > > > With this change we can use existing TCP functions with a > > different kind of memory storage as for instance the shared > > memory provided by the guest via vhost-user. > > > > Signed-off-by: Laurent Vivier > > Basically just code motion, so a kind of trivial > > Reviewed-by: David Gibson > > Of course, this will conflict with basically any change in tcp.c. > Stefano, I wonder if it's worth going ahead and merging this soon, so > neither Laurent nor I needs to keep rebasing. I think we're quite close to merge the whole series once Laurent addresses pending comments... I'll try to be quick once it happens. -- Stefano