From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E09BB5A004F for ; Wed, 12 Jun 2024 19:16:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718212619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k50vZePtProM/uGMP7Q0T0hfzJy0ihgdYhOxJbhaux4=; b=IytCBsRCjfAb0GT8SEpkVTw9mdfNIx8D92EkNPg8jw4Ggr9YjWUt81NBDp6hZV5Hx8v1UM uRPfZ5ynz7LHrQUyzGFw9Kct1Tmkz0j3HC6x9Tu49xUNpgaqfxQeIfJ6a3UxQtIuMr1hj5 GnCteK8Sth6UmBe7qvIQ16EAvARx278= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-RTRCzdRsPPSz8CivwgmQ3w-1; Wed, 12 Jun 2024 13:16:57 -0400 X-MC-Unique: RTRCzdRsPPSz8CivwgmQ3w-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-797e08e5d9eso1196885a.3 for ; Wed, 12 Jun 2024 10:16:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718212616; x=1718817416; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k50vZePtProM/uGMP7Q0T0hfzJy0ihgdYhOxJbhaux4=; b=HEKuRSIx+v2DmVHp6VN7IPASz1ubTerqy5cVKmy04Sqi7jQ5ZGXao2MDaTRqH2QgyJ ZD3i4RljvHEKse69lzrWPT2/LJygHkspnTTZIZl8rvk20N48fmZSnyxdvMZlOVsZ05U6 iZGSJx/82erg/somRiJvDO+gnUsKS3Q+9ezya1VbR4+5FX+E+kASipjPFtbQJqWc84B4 ossa7E9FifIMkzJ3GEJ/U5vE/9TQW+34FOt42IvZI4R724kO2T2QQEJ3X/wZGbyXfeBX rsDIXL2YhPvh5RP/hioYX30SXhpQu1t2icNSVO11LKjVgLd10EZX7MdvQHCUIVbftitn mwmw== X-Gm-Message-State: AOJu0YwTPE56sqYbDSdHJQ9Yw76VfXcByMDCaOTHVP1z+uv1Sz/VHNoi xBqI+J0wzwIi87306hdFBDzP1spXfuawBSk4yoCx9AtYBHxCoJIw1jggUs2zUbfX0pjcgUyNz01 C5uTUPkRY3k+Vi77sMNqBqaiyiKO33AN0Fgpth02lr8ZNiHhwVw5DLjQY/Ytg X-Received: by 2002:a05:6214:320f:b0:6b0:82cc:5e7a with SMTP id 6a1803df08f44-6b192028b71mr26015716d6.21.1718212616325; Wed, 12 Jun 2024 10:16:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQVaOJh0hl86dcMGoVD6j7aFGHhKjc03cFWRa1IGP1Q46fYclBMlcdQOkTYQ9NVC3/lkkGww== X-Received: by 2002:a05:6214:320f:b0:6b0:82cc:5e7a with SMTP id 6a1803df08f44-6b192028b71mr26015436d6.21.1718212615791; Wed, 12 Jun 2024 10:16:55 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b06cd275b7sm46798956d6.62.2024.06.12.10.16.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 10:16:55 -0700 (PDT) Date: Wed, 12 Jun 2024 19:16:17 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v6 0/8] Add vhost-user support to passt (part 2) Message-ID: <20240612191617.2ae465a8@elisabeth> In-Reply-To: <20240612154734.1044883-1-lvivier@redhat.com> References: <20240612154734.1044883-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IDSR2XPNQR5FFVOUF4MT5NPALK7DQXTW X-Message-ID-Hash: IDSR2XPNQR5FFVOUF4MT5NPALK7DQXTW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 17:47:26 +0200 Laurent Vivier wrote: > Extract buffers management code from tcp.c and move > it to tcp_buf.c > tcp.c keeps all the generic code and will be also used by > the vhost-user functions. > > Also compare mode to MODE_PASTA, as we will manage vhost-user > mode (MODE_VU) like MODE_PASST. Something in this series breaks the pasta_podman/bats test, number 19 in that script (Single TCP port forwarding, IPv4, tap). I'm bisecting now... -- Stefano