From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C91695A004F for ; Wed, 12 Jun 2024 19:38:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718213904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A1iXZQMVmsDUfh53unkHVrH5eC4nbSlqPDDM+U/dRyg=; b=XkzjCetxnHrGpbiwZ9yBdtoKBYurD6TCsd9NKa76B6w3lXsB48taDnk/5G9VNWn6542K1C db5y1dBHzWnbCc4XO7U3yiP2RgeeU0EV403e8fmMlxGeVtBXYkDWCectprQjFQToecboaH utRu9UELJ48DWogMjLAnzHS1jwrBnYE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-TI_bvQqfMQydgJfUmf2BGw-1; Wed, 12 Jun 2024 13:38:23 -0400 X-MC-Unique: TI_bvQqfMQydgJfUmf2BGw-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-44057432e8dso551151cf.1 for ; Wed, 12 Jun 2024 10:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718213902; x=1718818702; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A1iXZQMVmsDUfh53unkHVrH5eC4nbSlqPDDM+U/dRyg=; b=fcRWFbocb1Lw0q8r1KQzq5hZdymUCPaxUFuzXntvQIsM9pv68rVSYyy/BtQb1L1H/q 0HXSDhgKvrksXq1PmPXjmzgOf/TVR95uyR1MQPsuvIhH+7tBBthasScTGCB6czreZRsc +ha5FG7tKriegASwkylgssaZNLwWVYPzZpJ37ZaQ2FwXYfKSbvA+ntwXbWH3SKsL623S 5n4WSKN9xfMMxViymO1paqL8kUy3djp3B0yo/5zZRndP0/OeWFvhokHGFhf/Q8i5hd5Y TMZ5761pzi5e06C5pMhQVcHVzezJNzTqOnTiypE2+NLQKVuMgpT4mv3f1RJpsbnxhTA0 JHgw== X-Gm-Message-State: AOJu0YxBGXgbBZF7JC8IeEQfB/lNetYKFpoBkOHszYCMa/nsSPs53Tvx H3JXnVnDjpARRST5hTlfoxMqvkX4HbJyk73kNCvgeaxNTNWjWobqUffzQmpPfeSYzuc1XIsAXxO Vi5w+0nQLmvE2ZgMLE/fcelsr6X2ADPwVJf9UUktqLq806xAjhQ== X-Received: by 2002:a05:622a:15c7:b0:440:5f42:d8aa with SMTP id d75a77b69052e-4415ac65288mr29659431cf.57.1718213902392; Wed, 12 Jun 2024 10:38:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQjR55jlEf9ENV/OSOs4jFoyqnsL3+RqbfKiL2HT9JBbjABBQrw4QcahexbRD0AJiILiONZg== X-Received: by 2002:a05:622a:15c7:b0:440:5f42:d8aa with SMTP id d75a77b69052e-4415ac65288mr29659071cf.57.1718213901830; Wed, 12 Jun 2024 10:38:21 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44138034a9esm19671981cf.4.2024.06.12.10.38.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 10:38:21 -0700 (PDT) Date: Wed, 12 Jun 2024 19:37:44 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v6 0/8] Add vhost-user support to passt (part 2) Message-ID: <20240612193744.4897d940@elisabeth> In-Reply-To: <20240612191617.2ae465a8@elisabeth> References: <20240612154734.1044883-1-lvivier@redhat.com> <20240612191617.2ae465a8@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 26ZIYIPB6FVJ6GOFCQ25L3CIYQNL7QU4 X-Message-ID-Hash: 26ZIYIPB6FVJ6GOFCQ25L3CIYQNL7QU4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 19:16:17 +0200 Stefano Brivio wrote: > On Wed, 12 Jun 2024 17:47:26 +0200 > Laurent Vivier wrote: > > > Extract buffers management code from tcp.c and move > > it to tcp_buf.c > > tcp.c keeps all the generic code and will be also used by > > the vhost-user functions. > > > > Also compare mode to MODE_PASTA, as we will manage vhost-user > > mode (MODE_VU) like MODE_PASST. > > Something in this series breaks the pasta_podman/bats test, number 19 > in that script (Single TCP port forwarding, IPv4, tap). I'm bisecting > now... $ git bisect good 3c6a20486425ed00ba5b631bea11135045794dc2 is the first bad commit commit 3c6a20486425ed00ba5b631bea11135045794dc2 Author: Laurent Vivier Date: Wed Jun 12 17:47:34 2024 +0200 tap: use in->buf_size rather than sizeof(pkt_buf) buf_size is set to sizeof(pkt_buf) by default. And it seems more correct to provide the actual size of the buffer. Later a buf_size of 0 will allow vhost-user mode to detect guest memory buffers. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Signed-off-by: Stefano Brivio tap.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ...checking that patch now. -- Stefano