From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 520B55A004E for ; Thu, 13 Jun 2024 11:36:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718271395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+bfmjo7jhtuZB420OpFSdtehMsocQBTT5HZxskCmm/g=; b=KUv2fsJVSuJhPfxc34Nh56WccxMOgiAicJNzqibK9Uu3hbL9CJW8BF8E+/swvu5di05+/8 4IXULo9TU8AIoGNBiHUqjaX+BR1FNJh07sklw2GilMuXqs8JgTcX8F/k+dYKHEcIwnDRTY JanQxMxBiGSCc9XXIpnqmjnGqD38R94= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-hKXKQh6EMSWRDEvL1whjJw-1; Thu, 13 Jun 2024 05:36:32 -0400 X-MC-Unique: hKXKQh6EMSWRDEvL1whjJw-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-44057432e8dso7916741cf.1 for ; Thu, 13 Jun 2024 02:36:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718271391; x=1718876191; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+bfmjo7jhtuZB420OpFSdtehMsocQBTT5HZxskCmm/g=; b=ImOIFf3KdGPYlt27sJJ1A0wpWTKtWgvzlZqcnVS/8CedwuV6HF/xvqDcJ3MkRL8xQO YxFgC/tXaoyeldiM5uH50CKacrfSLF4lNoMZ5n5BJbe+pXBSPwNjt4ZU1Le2qzSC+N9e PcySKSXQ1Un0AxDFKgfFiWIcAq5zpblaQaAfXaAKosVMs5PfUaIX4X8n/hVJbA4kOueO lfk3+BDDmBl4Zlzt1KGrZBHTEQJn9uFC1zVQ2MFLfP9LcdZmZV0HoSzOadhyOggMQDQ0 yqADdxRKNzyjuJh2SN9DLEH5lJNlJVRmvR72S+LqlbUog9jFDgbYiIfaKQxjeEJK4MRE YSPg== X-Gm-Message-State: AOJu0Yw7v7zXOkelSvVE6wtX7TQBeAt9h6NIVm2Fe/JnTF6DhFUuJoGK +X4oNlRruWQk7pF8TvGhQmWBnAxIBzALyBiDOHenoDy9zfnniAcxzaccAP2IAqNgP9hu76REIfe DhEJAwOwar0a+XBMG+LQBwZWBkJoPM4yOQhLlYAO/cdchNRh5Cl7ISoSElOUf X-Received: by 2002:ac8:5f49:0:b0:441:2998:3e7b with SMTP id d75a77b69052e-4415abeac4bmr54212141cf.30.1718271391052; Thu, 13 Jun 2024 02:36:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8pPez+Qd4d3rgglOPAu97PTh6+i0zWqneBYZaHC4aZRLJHavnxmaSRnkLsH3w6HR5LeFoTw== X-Received: by 2002:ac8:5f49:0:b0:441:2998:3e7b with SMTP id d75a77b69052e-4415abeac4bmr54211941cf.30.1718271390491; Thu, 13 Jun 2024 02:36:30 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441f2fcc541sm4494921cf.77.2024.06.13.02.36.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2024 02:36:29 -0700 (PDT) Date: Thu, 13 Jun 2024 11:35:53 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v6 1/8] tcp: extract buffer management from tcp_send_flag() Message-ID: <20240613113553.1686f99b@elisabeth> In-Reply-To: References: <20240612154734.1044883-1-lvivier@redhat.com> <20240612154734.1044883-2-lvivier@redhat.com> <20240612232210.3b1f975f@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BXSZZHX23KBMVZ5ZL7YELDXEOHFQ26EX X-Message-ID-Hash: BXSZZHX23KBMVZ5ZL7YELDXEOHFQ26EX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 09:31:44 +0200 Laurent Vivier wrote: > On 12/06/2024 23:22, Stefano Brivio wrote: > > I couldn't find out why this patch breaks the the pasta_podman/bats > > test, yet, that is: > > > > not ok 19 [505] Single TCP port forwarding, IPv4, tap > > # (from function `bail-now' in file test/podman/test/system/helpers.bash, line 235, > > # from function `assert' in file test/podman/test/system/helpers.bash, line 929, > > # from function `pasta_test_do' in file test/podman/test/system/505-networking-pasta.bats, line 239, > > # in test file test/podman/test/system/505-networking-pasta.bats, line 472) > > # `pasta_test_do' failed > > # > > # [22:54:18.306131353] $ test/podman/bin/podman rm -t 0 --all --force --ignore > > # > > # [22:54:18.367462243] $ test/podman/bin/podman ps --all --external --format {{.ID}} {{.Names}} > > # > > # [22:54:18.394935392] $ test/podman/bin/podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}} > > # [22:54:18.419773379] quay.io/libpod/testimage:20240123 1f6acd4c4a1d > > # > > # [22:54:19.246631856] $ test/podman/bin/podman info --format {{.Host.Pasta.Executable}} > > # [22:54:20.084392405] /home/sbrivio/passt/pasta > > # > > # [22:54:20.167980222] $ test/podman/bin/podman run --net=pasta -p [88.198.0.164]:5727:5727/tcp quay.io/libpod/testimage:20240123 sh -c for port in $(seq 5727 5727); do socat -u TCP4-LISTEN:${port},bind=[88.198.0.164] STDOUT & done; wait > > # [22:54:37.256040883] x2024/06/12 20:54:37 socat[3] E read(6, 0x7fe675cd6000, 8192): Connection reset by peer > > # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv > > # #| FAIL: Mismatch between data sent and received > > # #| expected: = x > > # #| actual: x2024/06/12 20:54:37 socat\[3\] E read\(6\, 0x7fe675cd6000\, 8192\): Connection reset by peer > > # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > meaning that the data transfer is actually fine, but we reset the > > connection instead of an orderly shutdown. > > How do you run this test? It's in the test suite, see test/README.md. Make sure you have a local build of Podman with 'make podman' under test/. You can also skip other tests by commenting the rest out in test/run, then do ./run from test/. -- Stefano